Re: Review Request 38379: Handle empty set of cgroups as a no-op in perf::sample.

2015-09-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38379/#review98949 --- Ship it! Ship It! - Jie Yu On Sept. 14, 2015, 10:57 p.m., Ben Ma

Re: Review Request 38379: Handle empty set of cgroups as a no-op in perf::sample.

2015-09-14 Thread Ben Mahler
> On Sept. 14, 2015, 11:21 p.m., Cong Wang wrote: > > Not sure how much value this patch has, because upper layer always calls it > > with non-empty cgroups. Also, you probably want to check for events.empty() > > too while you are on it. This was done for https://reviews.apache.org/r/38380/,

Re: Review Request 38379: Handle empty set of cgroups as a no-op in perf::sample.

2015-09-14 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38379/#review98945 --- Not sure how much value this patch has, because upper layer always c