Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

2015-09-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38408/#review99087 --- src/tests/paths_tests.cpp (line 224)

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

2015-09-15 Thread Timothy Chen
> On Sept. 15, 2015, 8:51 p.m., Timothy Chen wrote: > > Ship It! Wierd, anyway fix it and ship it :) - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38408/#review99088 -

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

2015-09-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38408/#review99088 --- Ship it! Ship It! - Timothy Chen On Sept. 15, 2015, 6:51 p.m., J

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

2015-09-15 Thread Jie Yu
> On Sept. 15, 2015, 7:01 p.m., Jiang Yan Xu wrote: > > src/slave/paths.cpp, line 378 > > > > > > I don't think this needs to be changed to singular and the convention > > is that the plural form ("slaves", "framewo

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

2015-09-15 Thread Jiang Yan Xu
> On Sept. 15, 2015, 12:01 p.m., Jiang Yan Xu wrote: > > src/slave/paths.cpp, line 378 > > > > > > I don't think this needs to be changed to singular and the convention > > is that the plural form ("slaves", "framew

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

2015-09-15 Thread Jie Yu
> On Sept. 15, 2015, 7:01 p.m., Jiang Yan Xu wrote: > > src/slave/paths.cpp, line 378 > > > > > > I don't think this needs to be changed to singular and the convention > > is that the plural form ("slaves", "framewo

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

2015-09-15 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38408/#review99065 --- src/slave/containerizer/provisioner/paths.hpp (line 32)

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

2015-09-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38408/ --- (Updated Sept. 15, 2015, 6:51 p.m.) Review request for mesos, Timothy Chen and