Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-23 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/#review100296 --- Ship it! src/slave/slave.cpp (line 375)

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/#review100340 --- Patch looks great! Reviews applied: [38473] All tests passed. -

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-21 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/ --- (Updated Sept. 22, 2015, 12:22 a.m.) Review request for mesos, Benjamin

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/#review99912 --- Patch looks great! Reviews applied: [38473] All tests passed. -

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-21 Thread Cong Wang
> On Sept. 18, 2015, 10:57 p.m., Cong Wang wrote: > > Why not just set --host_name=$LIBPROCESS_IP for your case since you anyway > > need to provide a flag? > > Guangya Liu wrote: > I also have the same question with Cong, @Marco, can you please show more > detail for why not using the

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-21 Thread Marco Massenzio
> On Sept. 18, 2015, 10:57 p.m., Cong Wang wrote: > > Why not just set --host_name=$LIBPROCESS_IP for your case since you anyway > > need to provide a flag? > > Guangya Liu wrote: > I also have the same question with Cong, @Marco, can you please show more > detail for why not using the

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-21 Thread Marco Massenzio
> On Sept. 21, 2015, 7:39 p.m., Benjamin Hindman wrote: > > src/master/master.cpp, line 345 > > > > > > Why are you reading LIBPROCESS_IP here? Why not `flags.ip`? There > > appears to be a very non-obvious global

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-21 Thread Marco Massenzio
> On Sept. 18, 2015, 10:57 p.m., Cong Wang wrote: > > Why not just set --host_name=$LIBPROCESS_IP for your case since you anyway > > need to provide a flag? > > Guangya Liu wrote: > I also have the same question with Cong, @Marco, can you please show more > detail for why not using the

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-19 Thread Marco Massenzio
> On Sept. 18, 2015, 10:57 p.m., Cong Wang wrote: > > Why not just set --host_name=$LIBPROCESS_IP for your case since you anyway > > need to provide a flag? > > Guangya Liu wrote: > I also have the same question with Cong, @Marco, can you please show more > detail for why not using the

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/#review99658 --- Patch looks great! Reviews applied: [38473] All tests passed. -

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-18 Thread Guangya Liu
> On 九月 18, 2015, 10:57 p.m., Cong Wang wrote: > > Why not just set --host_name=$LIBPROCESS_IP for your case since you anyway > > need to provide a flag? I also have the same question with Cong, @Marco, can you please show more detail for why not using the solution as above? What is the

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-18 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/#review99628 --- Why not just set --host_name=$LIBPROCESS_IP for your case since you

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-18 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/ --- (Updated Sept. 18, 2015, 9:53 p.m.) Review request for mesos, Benjamin

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/#review99616 --- Ship it! Ship It! - Neil Conway On Sept. 18, 2015, 9:53 p.m.,