Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

2015-10-25 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38875/#review103959 --- Ship it! Ship It! - Ben Mahler On Oct. 24, 2015, 6:43 p.m., Ana

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

2015-10-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38875/ --- (Updated Oct. 24, 2015, 6:43 p.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

2015-10-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38875/ --- (Updated Oct. 24, 2015, 6:37 p.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

2015-10-05 Thread Anand Mazumdar
> On Oct. 5, 2015, 11:57 p.m., Isabel Jimenez wrote: > > src/slave/http.cpp, line 310 > > > > > > Could you please change the syntax for every case to be consistent with > > `: {` through this switch? > > Guangya L

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

2015-10-05 Thread Anand Mazumdar
> On Sept. 30, 2015, 5 a.m., Guangya Liu wrote: > > src/slave/http.cpp, line 304 > > > > > > Can you please add some comments for when this if condition will be > > hit? I see that the scheduler API is not handling

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

2015-10-05 Thread Guangya Liu
> On 十月 5, 2015, 11:57 p.m., Isabel Jimenez wrote: > > src/slave/http.cpp, line 310 > > > > > > Could you please change the syntax for every case to be consistent with > > `: {` through this switch? Does the "{" ne

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

2015-10-05 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38875/#review101562 --- src/slave/http.cpp (line 298)

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

2015-09-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38875/#review101074 --- src/slave/http.cpp (line 292)