Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review102867 --- - Timothy Chen On Oct. 9, 2015, 11:39 p.m., Gilbert Song wrote:

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review102866 --- Mesos style checker didn't pass for this patch. I'll fix this for

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-12 Thread Gilbert Song
> On Oct. 9, 2015, 3:22 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioner/docker/spec.hpp, line 38 > > > > > > Nit: s/validateManifest/validate > > > > We tend to use non-redundant names.

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/ --- (Updated Oct. 9, 2015, 4:39 p.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review102148 --- Patch looks great! Reviews applied: [38901, 38919] All tests

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-09 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review102136 --- Ship it! Ship It! - Anand Mazumdar On Oct. 9, 2015, 11:39

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/ --- (Updated Oct. 9, 2015, 3:24 p.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-09 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review102118 --- Mainly style nits otherwise looks pretty good.

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/ --- (Updated Oct. 9, 2015, 4:08 p.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/ --- (Updated Oct. 6, 2015, 12:08 p.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review101682 --- src/slave/containerizer/provisioner/docker/spec.cpp (line 62)

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review101693 --- Patch looks great! Reviews applied: [38901, 38919] All tests

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review101735 --- Patch looks great! Reviews applied: [38901, 38919] All tests

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/ --- (Updated Oct. 6, 2015, 3:35 p.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review101600 --- Patch looks great! Reviews applied: [38901, 38919] All tests

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-05 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/ --- (Updated Oct. 5, 2015, 1:51 p.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-01 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review101196 --- src/slave/containerizer/provisioner/docker/spec.cpp (line 42)

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review101198 --- Patch looks great! Reviews applied: [38901, 38919] All tests