Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review105611 --- Ship it! Ship It! - Adam B On Nov. 6, 2015, 4:18 p.m., Greg Man

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review105570 --- Patch looks great! Reviews applied: [39211, 39018, 39102] All tes

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review105568 --- Bad patch! Reviews applied: [39211, 39018] Failed command: ./supp

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- (Updated Nov. 7, 2015, 12:18 a.m.) Review request for mesos, Adam B and Neil Co

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review105540 --- Bad patch! Reviews applied: [39211, 39018] Failed command: ./supp

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- (Updated Nov. 6, 2015, 7:41 p.m.) Review request for mesos, Adam B and Neil Con

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review105246 --- Patch looks great! Reviews applied: [39211, 39018, 39102] All tes

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review105237 --- Looks great, but we need to fix the consistency issue between the

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- (Updated Nov. 4, 2015, 5:26 p.m.) Review request for mesos, Adam B and Neil Con

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review103052 --- Ship it! Ship It! - Guangya Liu On 十月 17, 2015, 11:05 p.m., Gre

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review103043 --- Patch looks great! Reviews applied: [39211, 39018, 39102] All tes

Re: Review Request 39102: Added documentation for JSON resources.

> On Oct. 17, 2015, 8:44 a.m., Guangya Liu wrote: > > Looks good. But we need first make sure the backend code merged first. > > https://reviews.apache.org/r/39018/ Thanks; altered this review to depend on 39018. - Greg --- This is an

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- (Updated Oct. 17, 2015, 11:05 p.m.) Review request for mesos, Adam B and Neil C

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review103019 --- Looks good. But we need first make sure the backend code merged fir

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review102102 --- Patch looks great! Reviews applied: [39102] All tests passed. -

Re: Review Request 39102: Added documentation for JSON resources.

> On Oct. 9, 2015, 9:35 a.m., Guangya Liu wrote: > > docs/attributes-resources.md, line 174 > > > > > > Do you mind to update three to five here? Nice catch! - Greg --

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- (Updated Oct. 9, 2015, 4:13 p.m.) Review request for mesos, Adam B and Neil Con

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review102040 --- docs/attributes-resources.md (line 174)

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review101934 --- Patch looks great! Reviews applied: [39102] All tests passed. -

Re: Review Request 39102: Added documentation for JSON resources.

> On Oct. 8, 2015, 6 a.m., Guangya Liu wrote: > > docs/attributes-resources.md, line 104 > > > > > > Can we use a real json string which can map to above resources? Yea we can; I was worried about the readability of

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- (Updated Oct. 8, 2015, 3:32 p.m.) Review request for mesos, Adam B and Neil Con

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review101873 --- docs/attributes-resources.md (line 104)

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- (Updated Oct. 8, 2015, 4:42 a.m.) Review request for mesos, Adam B and Neil Con

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review101850 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 39102: Added documentation for JSON resources.

> On Oct. 7, 2015, 9:29 p.m., Neil Conway wrote: > > docs/attributes-resources.md, line 39 > > > > > > What's a "key string"? good question! :-) changed. - Greg ---

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- (Updated Oct. 7, 2015, 11:59 p.m.) Review request for mesos. Changes ---

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review101813 --- docs/attributes-resources.md (line 39)