Re: Review Request 39459: Added docs for using delay() and clocks in libprocess.

2015-11-08 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39459/#review105642
---

Ship it!


Thanks Neil! I made a few minor edits so folks that copy this code before 
changing it for their needs will better match our style. Committing now.

- Benjamin Hindman


On Oct. 19, 2015, 11:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39459/
> ---
> 
> (Updated Oct. 19, 2015, 11:06 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Lots more to add, but this is a start.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39459/diff/
> 
> 
> Testing
> ---
> 
> Previewed via Github Gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39459: Added docs for using delay() and clocks in libprocess.

2015-10-19 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39459/#review103202
---

Ship it!


Ship It!

- Guangya Liu


On 十月 19, 2015, 11:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39459/
> ---
> 
> (Updated 十月 19, 2015, 11:06 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Lots more to add, but this is a start.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39459/diff/
> 
> 
> Testing
> ---
> 
> Previewed via Github Gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39459: Added docs for using delay() and clocks in libprocess.

2015-10-19 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39459/#review103199
---


Patch looks great!

Reviews applied: [39459]

All tests passed.

- Mesos ReviewBot


On Oct. 19, 2015, 11:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39459/
> ---
> 
> (Updated Oct. 19, 2015, 11:06 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Lots more to add, but this is a start.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39459/diff/
> 
> 
> Testing
> ---
> 
> Previewed via Github Gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39459: Added docs for using delay() and clocks in libprocess.

2015-10-19 Thread Neil Conway 


> On Oct. 19, 2015, 10:58 p.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/README.md, line 378
> > 
> >
> > Nit, How about:
> > 
> > ```A process that initiates
> > an asynchronous operation would like to know if the operation hasn't 
> > completed
> > within a certain time bound. To facilitate this, libprocess provides a 
> > set of
> > abstractions that simplify writing timeout logic.```

I was trying to support the idea that you can use timeouts for lots of things, 
although pursuing an alternative after an operation hasn't completed is a 
common case. Happy to change if you think your text is clearer though.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39459/#review103179
---


On Oct. 19, 2015, 11:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39459/
> ---
> 
> (Updated Oct. 19, 2015, 11:06 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Lots more to add, but this is a start.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39459/diff/
> 
> 
> Testing
> ---
> 
> Previewed via Github Gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39459: Added docs for using delay() and clocks in libprocess.

2015-10-19 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39459/
---

(Updated Oct. 19, 2015, 11:06 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Greg Mann.


Changes
---

Address review.


Repository: mesos


Description
---

Lots more to add, but this is a start.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39459/diff/


Testing
---

Previewed via Github Gist.


Thanks,

Neil Conway

Re: Review Request 39459: Added docs for using delay() and clocks in libprocess.

2015-10-19 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39459/#review103179
---

Ship it!


LGTM minus 2 small nits.


3rdparty/libprocess/README.md (line 378)


Nit, How about:

```A process that initiates
an asynchronous operation would like to know if the operation hasn't 
completed
within a certain time bound. To facilitate this, libprocess provides a set 
of
abstractions that simplify writing timeout logic.```



3rdparty/libprocess/README.md (line 430)


Nit: Can we pause the clock right before the `delay` statement ?


- Anand Mazumdar


On Oct. 19, 2015, 10:43 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39459/
> ---
> 
> (Updated Oct. 19, 2015, 10:43 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Lots more to add, but this is a start.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39459/diff/
> 
> 
> Testing
> ---
> 
> Previewed via Github Gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>