Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-12-01 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/#review108492
---

Ship it!


Ship It!

- Michael Park


On Nov. 30, 2015, 8:33 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39986/
> ---
> 
> (Updated Nov. 30, 2015, 8:33 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled the Authorizer to handle Reserve/Unreserve ACLs.
> Note: this review is continued from https://reviews.apache.org/r/37110/
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> c228c2b40ff5fdb007153101938f91ff269370a5 
>   src/authorizer/local/authorizer.hpp 
> bc3e4e12a35f222783159e35c4662e182ba0c107 
>   src/authorizer/local/authorizer.cpp 
> 853678b8fd3151d02fc77d5eadaf9948f33caebb 
>   src/tests/authorization_tests.cpp 32bcac731a6e8f8adb7298ed6c7174f6eb0499cb 
>   src/tests/mesos.hpp f097c683fed02240e9f54ac4491ab007f4652736 
>   src/tests/mesos.cpp a75182ec7f6d0c6063bbb36a6ccf4e8a4a81c8dd 
> 
> Diff: https://reviews.apache.org/r/39986/diff/
> 
> 
> Testing
> ---
> 
> The is the second in a chain of 5 patches. This diff includes new tests for 
> the authorization of reserve and unreserve operations via ACLs. `make check` 
> was used to test after all patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-30 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/
---

(Updated Nov. 30, 2015, 8:33 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Enabled the Authorizer to handle Reserve/Unreserve ACLs.
Note: this review is continued from https://reviews.apache.org/r/37110/


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
c228c2b40ff5fdb007153101938f91ff269370a5 
  src/authorizer/local/authorizer.hpp bc3e4e12a35f222783159e35c4662e182ba0c107 
  src/authorizer/local/authorizer.cpp 853678b8fd3151d02fc77d5eadaf9948f33caebb 
  src/tests/authorization_tests.cpp 32bcac731a6e8f8adb7298ed6c7174f6eb0499cb 
  src/tests/mesos.hpp f097c683fed02240e9f54ac4491ab007f4652736 
  src/tests/mesos.cpp a75182ec7f6d0c6063bbb36a6ccf4e8a4a81c8dd 

Diff: https://reviews.apache.org/r/39986/diff/


Testing
---

The is the second in a chain of 5 patches. This diff includes new tests for the 
authorization of reserve and unreserve operations via ACLs. `make check` was 
used to test after all patches were applied.


Thanks,

Greg Mann

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-16 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/
---

(Updated Nov. 16, 2015, 11:47 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Enabled the Authorizer to handle Reserve/Unreserve ACLs.
Note: this review is continued from https://reviews.apache.org/r/37110/


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
  src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 

Diff: https://reviews.apache.org/r/39986/diff/


Testing
---

The is the second in a chain of 5 patches. This diff includes new tests for the 
authorization of reserve and unreserve operations via ACLs. `make check` was 
used to test after all patches were applied.


Thanks,

Greg Mann

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-13 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/
---

(Updated Nov. 13, 2015, 11:12 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Changes
---

Changed ACL names.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Enabled the Authorizer to handle Reserve/Unreserve ACLs.
Note: this review is continued from https://reviews.apache.org/r/37110/


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 

Diff: https://reviews.apache.org/r/39986/diff/


Testing
---

The is the second in a chain of 5 patches. This diff includes new tests for the 
authorization of reserve and unreserve operations via ACLs. `make check` was 
used to test after all patches were applied.


Thanks,

Greg Mann

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-13 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/#review106512
---

Ship it!


Ship It!

- Jie Yu


On Nov. 13, 2015, 4:46 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39986/
> ---
> 
> (Updated Nov. 13, 2015, 4:46 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled the Authorizer to handle Reserve/Unreserve ACLs.
> Note: this review is continued from https://reviews.apache.org/r/37110/
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   src/authorizer/local/authorizer.hpp 
> 32de102fd588f029882ef121ca83a7410c65 
>   src/authorizer/local/authorizer.cpp 
> 6d7da87731a438c2180cf91003e09d4aa5a1c773 
>   src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
>   src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 
> 
> Diff: https://reviews.apache.org/r/39986/diff/
> 
> 
> Testing
> ---
> 
> The is the second in a chain of 5 patches. This diff includes new tests for 
> the authorization of reserve and unreserve operations via ACLs. `make check` 
> was used to test after all patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-12 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/
---

(Updated Nov. 13, 2015, 4:46 a.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Changes
---

Added comment in tests.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Enabled the Authorizer to handle Reserve/Unreserve ACLs.
Note: this review is continued from https://reviews.apache.org/r/37110/


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 

Diff: https://reviews.apache.org/r/39986/diff/


Testing
---

The is the second in a chain of 5 patches. This diff includes new tests for the 
authorization of reserve and unreserve operations via ACLs. `make check` was 
used to test after all patches were applied.


Thanks,

Greg Mann

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-12 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/
---

(Updated Nov. 13, 2015, 4:27 a.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Changes
---

Edited comments for style. Rebased.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Enabled the Authorizer to handle Reserve/Unreserve ACLs.
Note: this review is continued from https://reviews.apache.org/r/37110/


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 

Diff: https://reviews.apache.org/r/39986/diff/


Testing
---

The is the second in a chain of 5 patches. This diff includes new tests for the 
authorization of reserve and unreserve operations via ACLs. `make check` was 
used to test after all patches were applied.


Thanks,

Greg Mann

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-09 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/
---

(Updated Nov. 9, 2015, 5:26 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Enabled the Authorizer to handle Reserve/Unreserve ACLs.
Note: this review is continued from https://reviews.apache.org/r/37110/


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 

Diff: https://reviews.apache.org/r/39986/diff/


Testing
---

The is the second in a chain of 5 patches. This diff includes new tests for the 
authorization of reserve and unreserve operations via ACLs. `make check` was 
used to test after all patches were applied.


Thanks,

Greg Mann

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-08 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/
---

(Updated Nov. 9, 2015, 6:09 a.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Changes
---

Addressed comments.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Enabled the Authorizer to handle Reserve/Unreserve ACLs.
Note: this review is continued from https://reviews.apache.org/r/37110/


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
  src/tests/mesos.hpp 71eba8bb2689061e3bea3a5093e3e9c445362c68 

Diff: https://reviews.apache.org/r/39986/diff/


Testing
---

The is the second in a chain of 5 patches. This diff includes new tests for the 
authorization of reserve and unreserve operations via ACLs. `make check` was 
used to test after all patches were applied.


Thanks,

Greg Mann

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-07 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/#review105597
---



src/tests/authorization_tests.cpp (line 473)


s/which provides a default case which denies/which provides a default case 
that denies ?



src/tests/authorization_tests.cpp (line 549)


s/which provides a default case which denies/which provides a default case 
that denies ?


- Guangya Liu


On 十一月 6, 2015, 11:53 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39986/
> ---
> 
> (Updated 十一月 6, 2015, 11:53 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled the Authorizer to handle Reserve/Unreserve ACLs.
> Note: this review is continued from https://reviews.apache.org/r/37110/
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   src/authorizer/local/authorizer.hpp 
> 32de102fd588f029882ef121ca83a7410c65 
>   src/authorizer/local/authorizer.cpp 
> 6d7da87731a438c2180cf91003e09d4aa5a1c773 
>   src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
>   src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217 
> 
> Diff: https://reviews.apache.org/r/39986/diff/
> 
> 
> Testing
> ---
> 
> The is the second in a chain of 5 patches. This diff includes new tests for 
> the authorization of reserve and unreserve operations via ACLs. `make check` 
> was used to test after all patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-06 Thread Greg Mann 


> On Nov. 6, 2015, 7:35 a.m., Guangya Liu wrote:
> > src/tests/authorization_tests.cpp, lines 426-429
> > 
> >
> > Need a request test for this acl.

Good catch, thanks Guangya!


> On Nov. 6, 2015, 7:35 a.m., Guangya Liu wrote:
> > src/tests/authorization_tests.cpp, line 510
> > 
> >
> > Can we limit this to 70 chars?

As discussed in the other review, the style guide currently does not specify 70 
char comments, so I think the appropriate convention for all current patches is 
to wrap at 80 characters.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/#review105378
---


On Nov. 6, 2015, 11:53 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39986/
> ---
> 
> (Updated Nov. 6, 2015, 11:53 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled the Authorizer to handle Reserve/Unreserve ACLs.
> Note: this review is continued from https://reviews.apache.org/r/37110/
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   src/authorizer/local/authorizer.hpp 
> 32de102fd588f029882ef121ca83a7410c65 
>   src/authorizer/local/authorizer.cpp 
> 6d7da87731a438c2180cf91003e09d4aa5a1c773 
>   src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
>   src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217 
> 
> Diff: https://reviews.apache.org/r/39986/diff/
> 
> 
> Testing
> ---
> 
> The is the second in a chain of 5 patches. This diff includes new tests for 
> the authorization of reserve and unreserve operations via ACLs. `make check` 
> was used to test after all patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-06 Thread Greg Mann 


> On Nov. 6, 2015, 12:07 a.m., Till Toenshoff wrote:
> > src/tests/authorization_tests.cpp, line 411
> > 
> >
> > You already did a great job commenting your tests but could you also 
> > please add 1-2 lines of comment above all test function heads to briefly 
> > introduce their purpose? We made that a pattern we try to follow for all 
> > new tests.

Good call, thanks Till!


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/#review105323
---


On Nov. 6, 2015, 11:53 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39986/
> ---
> 
> (Updated Nov. 6, 2015, 11:53 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled the Authorizer to handle Reserve/Unreserve ACLs.
> Note: this review is continued from https://reviews.apache.org/r/37110/
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   src/authorizer/local/authorizer.hpp 
> 32de102fd588f029882ef121ca83a7410c65 
>   src/authorizer/local/authorizer.cpp 
> 6d7da87731a438c2180cf91003e09d4aa5a1c773 
>   src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
>   src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217 
> 
> Diff: https://reviews.apache.org/r/39986/diff/
> 
> 
> Testing
> ---
> 
> The is the second in a chain of 5 patches. This diff includes new tests for 
> the authorization of reserve and unreserve operations via ACLs. `make check` 
> was used to test after all patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-06 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/
---

(Updated Nov. 6, 2015, 11:53 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Changes
---

Addressed comments.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Enabled the Authorizer to handle Reserve/Unreserve ACLs.
Note: this review is continued from https://reviews.apache.org/r/37110/


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
  src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217 

Diff: https://reviews.apache.org/r/39986/diff/


Testing
---

The is the second in a chain of 5 patches. This diff includes new tests for the 
authorization of reserve and unreserve operations via ACLs. `make check` was 
used to test after all patches were applied.


Thanks,

Greg Mann

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-05 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/#review105378
---



src/tests/authorization_tests.cpp (lines 426 - 429)


Need a request test for this acl.



src/tests/authorization_tests.cpp (lines 491 - 494)


A request acl test for this?



src/tests/authorization_tests.cpp (line 510)


Can we limit this to 70 chars?


- Guangya Liu


On 十一月 5, 2015, 9:52 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39986/
> ---
> 
> (Updated 十一月 5, 2015, 9:52 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled the Authorizer to handle Reserve/Unreserve ACLs.
> Note: this review is continued from https://reviews.apache.org/r/37110/
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   src/authorizer/local/authorizer.hpp 
> 32de102fd588f029882ef121ca83a7410c65 
>   src/authorizer/local/authorizer.cpp 
> 6d7da87731a438c2180cf91003e09d4aa5a1c773 
>   src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
>   src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217 
> 
> Diff: https://reviews.apache.org/r/39986/diff/
> 
> 
> Testing
> ---
> 
> The is the second in a chain of 5 patches. This diff includes new tests for 
> the authorization of reserve and unreserve operations via ACLs. `make check` 
> was used to test after all patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-05 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/#review105323
---

Ship it!



src/tests/authorization_tests.cpp (line 411)


You already did a great job commenting your tests but could you also please 
add 1-2 lines of comment above all test function heads to briefly introduce 
their purpose? We made that a pattern we try to follow for all new tests.


- Till Toenshoff


On Nov. 5, 2015, 9:52 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39986/
> ---
> 
> (Updated Nov. 5, 2015, 9:52 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled the Authorizer to handle Reserve/Unreserve ACLs.
> Note: this review is continued from https://reviews.apache.org/r/37110/
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   src/authorizer/local/authorizer.hpp 
> 32de102fd588f029882ef121ca83a7410c65 
>   src/authorizer/local/authorizer.cpp 
> 6d7da87731a438c2180cf91003e09d4aa5a1c773 
>   src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
>   src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217 
> 
> Diff: https://reviews.apache.org/r/39986/diff/
> 
> 
> Testing
> ---
> 
> The is the second in a chain of 5 patches. This diff includes new tests for 
> the authorization of reserve and unreserve operations via ACLs. `make check` 
> was used to test after all patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-05 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/
---

(Updated Nov. 5, 2015, 9:52 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description (updated)
---

Enabled the Authorizer to handle Reserve/Unreserve ACLs.
Note: this review is continued from https://reviews.apache.org/r/37110/


Diffs
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
  src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217 

Diff: https://reviews.apache.org/r/39986/diff/


Testing
---

The is the second in a chain of 5 patches. This diff includes new tests for the 
authorization of reserve and unreserve operations via ACLs. `make check` was 
used to test after all patches were applied.


Thanks,

Greg Mann