Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

2015-11-26 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40654/#review108168
---

Ship it!


Ship It!

- Till Toenshoff


On Nov. 25, 2015, 2:32 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40654/
> ---
> 
> (Updated Nov. 25, 2015, 2:32 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up usage of `CreateSlaveFlags()` in a test file.
> 
> 
> Diffs
> -
> 
>   src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 
> 
> Diff: https://reviews.apache.org/r/40654/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

2015-11-25 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40654/#review107983
---

Ship it!


There are also other files need to be updated, but I think that we can update 
one by one.

- Guangya Liu


On 十一月 25, 2015, 2:32 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40654/
> ---
> 
> (Updated 十一月 25, 2015, 2:32 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up usage of `CreateSlaveFlags()` in a test file.
> 
> 
> Diffs
> -
> 
>   src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 
> 
> Diff: https://reviews.apache.org/r/40654/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

2015-11-24 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40654/
---

(Updated Nov. 25, 2015, 2:32 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

Rebase.


Repository: mesos


Description
---

Cleaned up usage of `CreateSlaveFlags()` in a test file.


Diffs (updated)
-

  src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 

Diff: https://reviews.apache.org/r/40654/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

2015-11-24 Thread Neil Conway 


> On Nov. 25, 2015, 2:25 a.m., Guangya Liu wrote:
> > src/tests/authentication_tests.cpp, line 311
> > 
> >
> > Not yours but do you mind to update s/Try >/Try> 
> > and the following?

Sure -- although I believe that committers would like to see these kinds of 
cleanups as a separate commit.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40654/#review107899
---


On Nov. 24, 2015, 4:54 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40654/
> ---
> 
> (Updated Nov. 24, 2015, 4:54 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up usage of `CreateSlaveFlags()` in a test file.
> 
> 
> Diffs
> -
> 
>   src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 
> 
> Diff: https://reviews.apache.org/r/40654/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

2015-11-24 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40654/#review107899
---



src/tests/authentication_tests.cpp (line 311)


Not yours but do you mind to update s/Try >/Try> and 
the following?


- Guangya Liu


On 十一月 24, 2015, 4:54 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40654/
> ---
> 
> (Updated 十一月 24, 2015, 4:54 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up usage of `CreateSlaveFlags()` in a test file.
> 
> 
> Diffs
> -
> 
>   src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 
> 
> Diff: https://reviews.apache.org/r/40654/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>