Re: Review Request 40697: Enhance endpoint /roles for adding a new role

2015-11-26 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40697/#review108183
---


Can you translate your test cases into GTest?

- Klaus Ma


On Nov. 26, 2015, 10:18 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40697/
> ---
> 
> (Updated Nov. 26, 2015, 10:18 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3942
> https://issues.apache.org/jira/browse/MESOS-3942
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enhance endpoint /roles for adding a new role
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp cffd20b2557b84b415940ab9af8d374c71b6627b 
>   src/master/master.hpp 0bb315a16801de9e7014ca0a83c5152faa75eb38 
>   src/master/role_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40697/diff/
> 
> 
> Testing
> ---
> 
> $ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST 
> http://127.0.0.1:5050/roles
> 
> $ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST 
> http://127.0.0.1:5050/roles
> Failed to validate set role request string: 
> ('role={"name":"role1","weight":2}')': This role already exist!
> 
> $ curl -X GET http://127.0.0.1:5050/roles/role1
> {"status":[{"infos":{"name":"role1","weight":2.0}}]}
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 40697: Enhance endpoint /roles for adding a new role

2015-11-26 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40697/#review108169
---


Patch looks great!

Reviews applied: [40431, 40424, 40697]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 26, 2015, 2:18 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40697/
> ---
> 
> (Updated Nov. 26, 2015, 2:18 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3942
> https://issues.apache.org/jira/browse/MESOS-3942
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enhance endpoint /roles for adding a new role
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp cffd20b2557b84b415940ab9af8d374c71b6627b 
>   src/master/master.hpp 0bb315a16801de9e7014ca0a83c5152faa75eb38 
>   src/master/role_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40697/diff/
> 
> 
> Testing
> ---
> 
> $ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST 
> http://127.0.0.1:5050/roles
> 
> $ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST 
> http://127.0.0.1:5050/roles
> Failed to validate set role request string: 
> ('role={"name":"role1","weight":2}')': This role already exist!
> 
> $ curl -X GET http://127.0.0.1:5050/roles/role1
> {"status":[{"infos":{"name":"role1","weight":2.0}}]}
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 40697: Enhance endpoint /roles for adding a new role

2015-11-26 Thread Yong Qiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40697/
---

(Updated Nov. 26, 2015, 2:18 p.m.)


Review request for mesos and Adam B.


Bugs: MESOS-3942
https://issues.apache.org/jira/browse/MESOS-3942


Repository: mesos


Description
---

Enhance endpoint /roles for adding a new role


Diffs (updated)
-

  src/master/http.cpp cffd20b2557b84b415940ab9af8d374c71b6627b 
  src/master/master.hpp 0bb315a16801de9e7014ca0a83c5152faa75eb38 
  src/master/role_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40697/diff/


Testing
---

$ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST 
http://127.0.0.1:5050/roles

$ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST 
http://127.0.0.1:5050/roles
Failed to validate set role request string: 
('role={"name":"role1","weight":2}')': This role already exist!

$ curl -X GET http://127.0.0.1:5050/roles/role1
{"status":[{"infos":{"name":"role1","weight":2.0}}]}


Thanks,

Yong Qiao Wang

Re: Review Request 40697: Enhance endpoint /roles for adding a new role

2015-11-25 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40697/#review108024
---


Bad patch!

Reviews applied: [40431]

Failed command: ./support/apply-review.sh -n -r 40431

Error:
 2015-11-25 17:13:42 URL:https://reviews.apache.org/r/40431/diff/raw/ 
[12510/12510] -> "40431.patch" [1]
error: patch failed: src/master/master.hpp:1985
error: src/master/master.hpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 25, 2015, 8:30 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40697/
> ---
> 
> (Updated Nov. 25, 2015, 8:30 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3942
> https://issues.apache.org/jira/browse/MESOS-3942
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enhance endpoint /roles for adding a new role
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 6c647808a48879cbc176ffe7586c7e9b41bcf4c8 
>   src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66 
>   src/master/role_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40697/diff/
> 
> 
> Testing
> ---
> 
> $ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST 
> http://127.0.0.1:5050/roles
> 
> $ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST 
> http://127.0.0.1:5050/roles
> Failed to validate set role request string: 
> ('role={"name":"role1","weight":2}')': This role already exist!
> 
> $ curl -X GET http://127.0.0.1:5050/roles/role1
> {"status":[{"infos":{"name":"role1","weight":2.0}}]}
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 40697: Enhance endpoint /roles for adding a new role

2015-11-25 Thread Yong Qiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40697/
---

(Updated Nov. 25, 2015, 8:30 a.m.)


Review request for mesos and Adam B.


Bugs: MESOS-3942
https://issues.apache.org/jira/browse/MESOS-3942


Repository: mesos


Description
---

Enhance endpoint /roles for adding a new role


Diffs
-

  src/master/http.cpp 6c647808a48879cbc176ffe7586c7e9b41bcf4c8 
  src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66 
  src/master/role_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40697/diff/


Testing
---

$ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST 
http://127.0.0.1:5050/roles

$ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST 
http://127.0.0.1:5050/roles
Failed to validate set role request string: 
('role={"name":"role1","weight":2}')': This role already exist!

$ curl -X GET http://127.0.0.1:5050/roles/role1
{"status":[{"infos":{"name":"role1","weight":2.0}}]}


Thanks,

Yong Qiao Wang