Re: Review Request 40755: Introduced filter for non-revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40755/#review108269 --- Ship it! Ship It! - Michael Park On Nov. 27, 2015, 2:46 p.m., A

Re: Review Request 40755: Introduced filter for non-revocable resources.

> On 十一月 27, 2015, 12:54 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 779 > > > > > > 1) v1 should also be updated > > 2) Add a unit test for this new type? > > Alexander Rukletsov wrote: > Go

Re: Review Request 40755: Introduced filter for non-revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40755/#review108249 --- Ship it! Ship It! - Guangya Liu On 十一月 27, 2015, 2:46 p.m., Ale

Re: Review Request 40755: Introduced filter for non-revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40755/#review108248 --- Ship it! Ship It! - Klaus Ma On Nov. 27, 2015, 10:46 p.m., Alex

Re: Review Request 40755: Introduced filter for non-revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40755/ --- (Updated Nov. 27, 2015, 2:46 p.m.) Review request for mesos, Ian Downes and Mic

Re: Review Request 40755: Introduced filter for non-revocable resources.

> On Nov. 27, 2015, 2:32 a.m., Michael Park wrote: > > src/common/resources.cpp, lines 777-778 > > > > > > I think it would be simpler if we were to just use a lambda here, what > > do you think? > > > > `

Re: Review Request 40755: Introduced filter for non-revocable resources.

> On Nov. 27, 2015, 12:34 a.m., Klaus Ma wrote: > > src/common/resources.cpp, line 775 > > > > > > Any UT cases for it? > > Alexander Rukletsov wrote: > What is a UT case? google points me to > https://en.wikip

Re: Review Request 40755: Introduced filter for non-revocable resources.

> On Nov. 27, 2015, 12:54 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 779 > > > > > > 1) v1 should also be updated > > 2) Add a unit test for this new type? Good catch, thanks! Do we have a doc w

Re: Review Request 40755: Introduced filter for non-revocable resources.

> On Nov. 27, 2015, 8:34 a.m., Klaus Ma wrote: > > src/common/resources.cpp, line 775 > > > > > > Any UT cases for it? > > Alexander Rukletsov wrote: > What is a UT case? google points me to > https://en.wikipe

Re: Review Request 40755: Introduced filter for non-revocable resources.

> On Nov. 27, 2015, 12:34 a.m., Klaus Ma wrote: > > src/common/resources.cpp, line 775 > > > > > > Any UT cases for it? What is a UT case? google points me to https://en.wikipedia.org/wiki/Fisher_v._University_of_T

Re: Review Request 40755: Introduced filter for non-revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40755/#review108182 --- src/common/resources.cpp (lines 777 - 778)

Re: Review Request 40755: Introduced filter for non-revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40755/#review108176 --- src/common/resources.cpp (line 779)

Re: Review Request 40755: Introduced filter for non-revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40755/#review108174 --- src/common/resources.cpp (line 775)