Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-21 Thread Joseph Wu 


> On Dec. 20, 2015, 3:01 p.m., Benjamin Hindman wrote:
> > This looks fine, assuming that we actually need `CreateContainerLogger` 
> > (see below).
> 
> Benjamin Hindman wrote:
> I looked ahead in the review chain and it doesn't look like you ever 
> extend `CreateContainerLogger`, so why was it necessary? Why couldn't you 
> just call `ContainerLogger::create`?

Removed the test helper from the review chain.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41169/#review111428
---


On Dec. 21, 2015, 11:37 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41169/
> ---
> 
> (Updated Dec. 21, 2015, 11:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4088
> https://issues.apache.org/jira/browse/MESOS-4088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> f1dd81bbf4bb42aebd6295e15973b7438bc9f9e7 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> fe679354d04d68b68e168cd8c4eab23898f6532f 
> 
> Diff: https://reviews.apache.org/r/41169/diff/
> 
> 
> Testing
> ---
> 
> make (OSX, Centos7, Ubuntu 14, Debian 8)
> make check (OSX, Centos7, Ubuntu 14, Debian 8)
> sudo bin/mesos-tests.sh (Centos7, Ubuntu 14, Debian 8)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-21 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41169/
---

(Updated Dec. 21, 2015, 11:37 a.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
---

Removed `CreateContainerLogger` helper and replaced with 
`ContainerLogger::create(...)` directly.


Bugs: MESOS-4088
https://issues.apache.org/jira/browse/MESOS-4088


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/containerizer/filesystem_isolator_tests.cpp 
f1dd81bbf4bb42aebd6295e15973b7438bc9f9e7 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
fe679354d04d68b68e168cd8c4eab23898f6532f 

Diff: https://reviews.apache.org/r/41169/diff/


Testing
---

make (OSX, Centos7, Ubuntu 14, Debian 8)
make check (OSX, Centos7, Ubuntu 14, Debian 8)
sudo bin/mesos-tests.sh (Centos7, Ubuntu 14, Debian 8)


Thanks,

Joseph Wu

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-20 Thread Benjamin Hindman 


> On Dec. 20, 2015, 11:01 p.m., Benjamin Hindman wrote:
> > This looks fine, assuming that we actually need `CreateContainerLogger` 
> > (see below).

I looked ahead in the review chain and it doesn't look like you ever extend 
`CreateContainerLogger`, so why was it necessary? Why couldn't you just call 
`ContainerLogger::create`?


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41169/#review111428
---


On Dec. 15, 2015, 8:40 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41169/
> ---
> 
> (Updated Dec. 15, 2015, 8:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4088
> https://issues.apache.org/jira/browse/MESOS-4088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> f1dd81bbf4bb42aebd6295e15973b7438bc9f9e7 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> fe679354d04d68b68e168cd8c4eab23898f6532f 
> 
> Diff: https://reviews.apache.org/r/41169/diff/
> 
> 
> Testing
> ---
> 
> make (OSX, Centos7, Ubuntu 14, Debian 8)
> make check (OSX, Centos7, Ubuntu 14, Debian 8)
> sudo bin/mesos-tests.sh (Centos7, Ubuntu 14, Debian 8)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-20 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41169/#review111428
---

Ship it!


This looks fine, assuming that we actually need `CreateContainerLogger` (see 
below).


src/tests/containerizer/filesystem_isolator_tests.cpp (line 174)


I still haven't seen why you need `CreateContainerLogger` instead of just 
`ContainerLogger::create`, just like we use `LinuxLauncher::create` above ... 
but I'm sure I'll see it soon enough! ;-)


- Benjamin Hindman


On Dec. 15, 2015, 8:40 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41169/
> ---
> 
> (Updated Dec. 15, 2015, 8:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4088
> https://issues.apache.org/jira/browse/MESOS-4088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> f1dd81bbf4bb42aebd6295e15973b7438bc9f9e7 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> fe679354d04d68b68e168cd8c4eab23898f6532f 
> 
> Diff: https://reviews.apache.org/r/41169/diff/
> 
> 
> Testing
> ---
> 
> make (OSX, Centos7, Ubuntu 14, Debian 8)
> make check (OSX, Centos7, Ubuntu 14, Debian 8)
> sudo bin/mesos-tests.sh (Centos7, Ubuntu 14, Debian 8)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-15 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41169/
---

(Updated Dec. 15, 2015, 12:40 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
---

Moved `initialize` into `create`. Remove `options` in favor of module 
parameters.


Bugs: MESOS-4088
https://issues.apache.org/jira/browse/MESOS-4088


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/containerizer/filesystem_isolator_tests.cpp 
f1dd81bbf4bb42aebd6295e15973b7438bc9f9e7 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
fe679354d04d68b68e168cd8c4eab23898f6532f 

Diff: https://reviews.apache.org/r/41169/diff/


Testing
---

make (OSX, Centos7, Ubuntu 14, Debian 8)
make check (OSX, Centos7, Ubuntu 14, Debian 8)
sudo bin/mesos-tests.sh (Centos7, Ubuntu 14, Debian 8)


Thanks,

Joseph Wu

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-14 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41169/
---

(Updated Dec. 14, 2015, 3:49 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
---

Remove lots and lots of now-unneeded test changes.


Bugs: MESOS-4088
https://issues.apache.org/jira/browse/MESOS-4088


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/containerizer/filesystem_isolator_tests.cpp 
f1dd81bbf4bb42aebd6295e15973b7438bc9f9e7 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
fe679354d04d68b68e168cd8c4eab23898f6532f 

Diff: https://reviews.apache.org/r/41169/diff/


Testing
---

make (OSX, Centos7, Ubuntu 14, Debian 8)
make check (OSX, Centos7, Ubuntu 14, Debian 8)
sudo bin/mesos-tests.sh (Centos7, Ubuntu 14, Debian 8)


Thanks,

Joseph Wu

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-11 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41169/
---

(Updated Dec. 11, 2015, 4:40 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
---

Rename from ExecutorLogger to ContainerLogger.


Summary (updated)
-

Logger Module: Update tests that use the MesosContainerizer to pass in an 
ContainerLogger


Bugs: MESOS-4088
https://issues.apache.org/jira/browse/MESOS-4088


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/container_logger_tests.cpp PRE-CREATION 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
f1dd81bbf4bb42aebd6295e15973b7438bc9f9e7 
  src/tests/containerizer/isolator_tests.cpp 
91178b69ccbf5b6cbf64421e5602e6d554fc34ca 
  src/tests/containerizer/memory_pressure_tests.cpp 
ed440fc05f8bda792b6cec9a591f465964e13404 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
fe679354d04d68b68e168cd8c4eab23898f6532f 
  src/tests/containerizer/port_mapping_tests.cpp 
9bcf05ec071b44156b57d8515f47ee6a8bbfdfa0 
  src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d 
  src/tests/fetcher_cache_tests.cpp 1fb1e213d3c35479789688d1a3a49a3c6058b198 
  src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566 
  src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187 
  src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 
  src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 

Diff: https://reviews.apache.org/r/41169/diff/


Testing
---

make (OSX, Centos7, Ubuntu 14, Debian 8)
make check (OSX, Centos7, Ubuntu 14, Debian 8)
sudo bin/mesos-tests.sh (Centos7, Ubuntu 14, Debian 8)


Thanks,

Joseph Wu