Re: Review Request 41398: Added expectation for call to mocked function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41398/#review111424 --- Ship it! Ship It! - Till Toenshoff On Dec. 20, 2015, 10:39 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41398/ > --- > > (Updated Dec. 20, 2015, 10:39 p.m.) > > > Review request for mesos, Jie Yu, Neil Conway, and Till Toenshoff. > > > Bugs: MESOS-4151 > https://issues.apache.org/jira/browse/MESOS-4151 > > > Repository: mesos > > > Description > --- > > We use a mocked executor here and need to register an expectation on a > call to its mocked `shutdown` method, like is already done at other > sites in this test suite. > > Review: https://reviews.apache.org/r/41398 > > > Diffs > - > > src/tests/slave_tests.cpp f19199344b8b542ebad1e59f4b97d8ca661aeb06 > > Diff: https://reviews.apache.org/r/41398/diff/ > > > Testing > --- > > `make check` under OS X > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 41398: Added expectation for call to mocked function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41398/ --- (Updated Dec. 16, 2015, 9:28 a.m.) Review request for mesos, Neil Conway and Till Toenshoff. Changes --- Added an actual description. Bugs: MESOS-4151 https://issues.apache.org/jira/browse/MESOS-4151 Repository: mesos Description (updated) --- We use a mocked executor here and need to register an expectation on a call to its mocked `shutdown` method, like is already done at other sites in this test suite. Review: https://reviews.apache.org/r/41398 Diffs (updated) - src/tests/slave_tests.cpp f19199344b8b542ebad1e59f4b97d8ca661aeb06 Diff: https://reviews.apache.org/r/41398/diff/ Testing --- `make check` under OS X Thanks, Benjamin Bannier
Re: Review Request 41398: Added expectation for call to mocked function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41398/#review110501 --- Patch looks great! Reviews applied: [41398] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Dec. 15, 2015, 2:28 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41398/ > --- > > (Updated Dec. 15, 2015, 2:28 p.m.) > > > Review request for mesos, Neil Conway and Till Toenshoff. > > > Bugs: MESOS-4151 > https://issues.apache.org/jira/browse/MESOS-4151 > > > Repository: mesos > > > Description > --- > > Added expectation for call to mocked function. > > > Diffs > - > > src/tests/slave_tests.cpp f19199344b8b542ebad1e59f4b97d8ca661aeb06 > > Diff: https://reviews.apache.org/r/41398/diff/ > > > Testing > --- > > `make check` under OS X > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 41398: Added expectation for call to mocked function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41398/#review110510 --- Ship it! LGTM Also, can we add a bit more context into the description of the CR ? I know that the relevant JIRA has the details but it's cumbersome to open up the review from doing a `git log` and backtrace. - Anand Mazumdar On Dec. 15, 2015, 2:28 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41398/ > --- > > (Updated Dec. 15, 2015, 2:28 p.m.) > > > Review request for mesos, Neil Conway and Till Toenshoff. > > > Bugs: MESOS-4151 > https://issues.apache.org/jira/browse/MESOS-4151 > > > Repository: mesos > > > Description > --- > > Added expectation for call to mocked function. > > > Diffs > - > > src/tests/slave_tests.cpp f19199344b8b542ebad1e59f4b97d8ca661aeb06 > > Diff: https://reviews.apache.org/r/41398/diff/ > > > Testing > --- > > `make check` under OS X > > > Thanks, > > Benjamin Bannier > >
