Re: Review Request 41424: Install picojson.h if we are using the bundled version.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41424/#review112602 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 22, 2015, 8:44 p.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41424/ > --- > > (Updated Dec. 22, 2015, 8:44 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Alex Clemmer, Joris > Van Remoortere, Joseph Wu, and Niklas Nielsen. > > > Bugs: MESOS-3909 > https://issues.apache.org/jira/browse/MESOS-3909 > > > Repository: mesos > > > Description > --- > > The Stout JSON API depends on picojson.h, so we need to install it > to be able to build Mesos modules outside the Mesos source tree. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/Makefile.am > 04d0fa324bf6eab98a51fc08298b9da2992d29d1 > > Diff: https://reviews.apache.org/r/41424/diff/ > > > Testing > --- > > Build an external module that implicitly depends on picojson.h > > > Thanks, > > James Peach > >
Re: Review Request 41424: Install picojson.h if we are using the bundled version.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41424/#review111807 --- Ship it! Much in the spirit of my review of #41425, it's interesting to consider what our distribution story should be in CMake. We currently have not implemented of the distribution logic, but it's definitely coming down the pike. the person _en pointe_ for that is `darroyo`, can we please add her to the review to get her feedback? In the meantime I'll open a JIRA to track this work. To summarize what I will say there: since CMake is expected to work on Windows, it does not natively create a `make dist` target for you. So I suspect that a "complete" solution is to (1) create a `dist` target on non-Windows platforms, which will wrap CPack, which is how we would build distributions with CMake; and (2) audit the contents of the distribution in the autotools solution, and replicate them in CMake. An example is here[1] and I expect our solution will be very similar. [1] http://agateau.com/2009/cmake-and-make-dist-the-simple-version/ - Alex Clemmer On Dec. 22, 2015, 8:44 p.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41424/ > --- > > (Updated Dec. 22, 2015, 8:44 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Alex Clemmer, Joris > Van Remoortere, Joseph Wu, and Niklas Nielsen. > > > Bugs: MESOS-3909 > https://issues.apache.org/jira/browse/MESOS-3909 > > > Repository: mesos > > > Description > --- > > The Stout JSON API depends on picojson.h, so we need to install it > to be able to build Mesos modules outside the Mesos source tree. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/Makefile.am > 04d0fa324bf6eab98a51fc08298b9da2992d29d1 > > Diff: https://reviews.apache.org/r/41424/diff/ > > > Testing > --- > > Build an external module that implicitly depends on picojson.h > > > Thanks, > > James Peach > >
Re: Review Request 41424: Install picojson.h if we are using the bundled version.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41424/#review111661 --- Ship it! Verified this does not break a clean build. - Joseph Wu On Dec. 22, 2015, 12:44 p.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41424/ > --- > > (Updated Dec. 22, 2015, 12:44 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Alex Clemmer, Joris > Van Remoortere, Joseph Wu, and Niklas Nielsen. > > > Bugs: MESOS-3909 > https://issues.apache.org/jira/browse/MESOS-3909 > > > Repository: mesos > > > Description > --- > > The Stout JSON API depends on picojson.h, so we need to install it > to be able to build Mesos modules outside the Mesos source tree. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/Makefile.am > 04d0fa324bf6eab98a51fc08298b9da2992d29d1 > > Diff: https://reviews.apache.org/r/41424/diff/ > > > Testing > --- > > Build an external module that implicitly depends on picojson.h > > > Thanks, > > James Peach > >
Re: Review Request 41424: Install picojson.h if we are using the bundled version.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41424/ --- (Updated Dec. 16, 2015, 5:24 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Joseph Wu, and Niklas Nielsen. Changes --- Updated dependencies so Make understands where picojson.h comes from. Bugs: MESOS-3909 https://issues.apache.org/jira/browse/MESOS-3909 Repository: mesos Description --- The Stout JSON API depends on picojson.h, so we need to install it to be able to build Mesos modules outside the Mesos source tree. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 04d0fa324bf6eab98a51fc08298b9da2992d29d1 Diff: https://reviews.apache.org/r/41424/diff/ Testing --- Build an external module that implicitly depends on picojson.h Thanks, James Peach
Re: Review Request 41424: Install picojson.h if we are using the bundled version.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41424/#review110679 --- Looks like this might be problematic on a clean build (reviewbot error on the next review): ``` make[7]: *** No rule to make target `picojson-1.3.0/picojson.h', needed by `all-am'. Stop. make[7]: *** Waiting for unfinished jobs ``` - Joseph Wu On Dec. 15, 2015, 4:10 p.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41424/ > --- > > (Updated Dec. 15, 2015, 4:10 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Joseph Wu, and Niklas > Nielsen. > > > Bugs: MESOS-3909 > https://issues.apache.org/jira/browse/MESOS-3909 > > > Repository: mesos > > > Description > --- > > The Stout JSON API depends on picojson.h, so we need to install it > to be able to build Mesos modules outside the Mesos source tree. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/Makefile.am > 04d0fa324bf6eab98a51fc08298b9da2992d29d1 > > Diff: https://reviews.apache.org/r/41424/diff/ > > > Testing > --- > > Build an external module that implicitly depends on picojson.h > > > Thanks, > > James Peach > >
