Re: Review Request 41474: Added documentation for `defer` in libprocess README.

2015-12-20 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/#review111435 --- Ship it! Thanks Greg! I made a few more tweaks given the complicat

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

2015-12-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/#review111422 --- Patch looks great! Reviews applied: [41474] Passed command: expor

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

2015-12-20 Thread Greg Mann
> On Dec. 19, 2015, 3:03 a.m., Neil Conway wrote: > > 3rdparty/libprocess/README.md, line 211 > > > > > > What is this used for? I just removed the boilerplate methods that are not relevant to the discussion at han

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

2015-12-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/ --- (Updated Dec. 20, 2015, 7:50 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

2015-12-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/ --- (Updated Dec. 20, 2015, 7:46 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

2015-12-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/#review111357 --- Patch looks great! Reviews applied: [41474] Passed command: expor

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

2015-12-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/#review111352 --- 3rdparty/libprocess/README.md (line 107)

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

2015-12-18 Thread Greg Mann
> On Dec. 18, 2015, 10:37 p.m., Neil Conway wrote: > > 3rdparty/libprocess/README.md, line 150 > > > > > > The need to use `lambda::_1` here is a bit unfortunate. I added a comment to clarify this. > On Dec. 18, 2

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

2015-12-18 Thread Greg Mann
> On Dec. 18, 2015, 10:43 p.m., Neil Conway wrote: > > 3rdparty/libprocess/README.md, line 176 > > > > > > We should be consistent (between code samples) about whether we're > > assuming any `using` statements are i

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

2015-12-18 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/ --- (Updated Dec. 19, 2015, 1:26 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

2015-12-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/#review111297 --- 3rdparty/libprocess/README.md (line 176)

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

2015-12-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/#review111287 --- 3rdparty/libprocess/README.md (line 106)