Re: Review Request 41891: Renaming offers to outstanding offers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41891/#review112890 --- Ship it! Ship It! - Vinod Kone On Jan. 5, 2016, 1:35 a.m., Diogo Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41891/ > --- > > (Updated Jan. 5, 2016, 1:35 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3817 > https://issues.apache.org/jira/browse/MESOS-3817 > > > Repository: mesos > > > Description > --- > > Renaming offers to outstanding offers. > > > Diffs > - > > src/webui/master/static/offers.html > cc199352fcf2074dcd0e8d24bb49651b38c41d86 > > Diff: https://reviews.apache.org/r/41891/diff/ > > > Testing > --- > > Can be tested running Mesos Master web-ui front page and offers page (now > named as Outstanding Offers). Only html changed. > > > Thanks, > > Diogo Gomes > >
Re: Review Request 41891: Renaming offers to outstanding offers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41891/#review112764 --- Patch looks great! Reviews applied: [41891] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 5, 2016, 1:35 a.m., Diogo Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41891/ > --- > > (Updated Jan. 5, 2016, 1:35 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3817 > https://issues.apache.org/jira/browse/MESOS-3817 > > > Repository: mesos > > > Description > --- > > Renaming offers to outstanding offers. > > > Diffs > - > > src/webui/master/static/offers.html > cc199352fcf2074dcd0e8d24bb49651b38c41d86 > > Diff: https://reviews.apache.org/r/41891/diff/ > > > Testing > --- > > Can be tested running Mesos Master web-ui front page and offers page (now > named as Outstanding Offers). Only html changed. > > > Thanks, > > Diogo Gomes > >
Re: Review Request 41891: Renaming offers to outstanding offers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41891/ --- (Updated Jan. 4, 2016, 11:35 p.m.) Review request for mesos and Vinod Kone. Changes --- Changing menu title to Offers again, as Vinod suggested.  Bugs: MESOS-3817 https://issues.apache.org/jira/browse/MESOS-3817 Repository: mesos Description --- Renaming offers to outstanding offers. Diffs (updated) - src/webui/master/static/offers.html cc199352fcf2074dcd0e8d24bb49651b38c41d86 Diff: https://reviews.apache.org/r/41891/diff/ Testing --- Can be tested running Mesos Master web-ui front page and offers page (now named as Outstanding Offers). Only html changed. Thanks, Diogo Gomes
Re: Review Request 41891: Renaming offers to outstanding offers.
> On Jan. 4, 2016, 10:26 p.m., Vinod Kone wrote: > > Can you attach the screenshot of the webui with these changes? > > Diogo Gomes wrote: > Sure: > > index.html > >  > > offers.html > >  > > Vinod Kone wrote: > How about justing calling it "Offers" in the black band? That way it is > consistent with "Frameowrks" and "Slaves" which do not have any qualifiers. > Also, it leaves the door open for the "Offers" page to have more than > "Outstanding Offers" in the future (e.g., accepted offers, declined offers > etc). Totally agree, I'll change the commit and update here - Diogo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41891/#review112710 --- On Jan. 4, 2016, 10:23 p.m., Diogo Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41891/ > --- > > (Updated Jan. 4, 2016, 10:23 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3817 > https://issues.apache.org/jira/browse/MESOS-3817 > > > Repository: mesos > > > Description > --- > > Renaming offers to outstanding offers. > > > Diffs > - > > src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 > src/webui/master/static/offers.html > cc199352fcf2074dcd0e8d24bb49651b38c41d86 > > Diff: https://reviews.apache.org/r/41891/diff/ > > > Testing > --- > > Can be tested running Mesos Master web-ui front page and offers page (now > named as Outstanding Offers). Only html changed. > > > Thanks, > > Diogo Gomes > >
Re: Review Request 41891: Renaming offers to outstanding offers.
> On Jan. 5, 2016, 12:26 a.m., Vinod Kone wrote: > > Can you attach the screenshot of the webui with these changes? > > Diogo Gomes wrote: > Sure: > > index.html > >  > > offers.html > >  How about justing calling it "Offers" in the black band? That way it is consistent with "Frameowrks" and "Slaves" which do not have any qualifiers. Also, it leaves the door open for the "Offers" page to have more than "Outstanding Offers" in the future (e.g., accepted offers, declined offers etc). - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41891/#review112710 --- On Jan. 5, 2016, 12:23 a.m., Diogo Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41891/ > --- > > (Updated Jan. 5, 2016, 12:23 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3817 > https://issues.apache.org/jira/browse/MESOS-3817 > > > Repository: mesos > > > Description > --- > > Renaming offers to outstanding offers. > > > Diffs > - > > src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 > src/webui/master/static/offers.html > cc199352fcf2074dcd0e8d24bb49651b38c41d86 > > Diff: https://reviews.apache.org/r/41891/diff/ > > > Testing > --- > > Can be tested running Mesos Master web-ui front page and offers page (now > named as Outstanding Offers). Only html changed. > > > Thanks, > > Diogo Gomes > >
Re: Review Request 41891: Renaming offers to outstanding offers.
> On Jan. 4, 2016, 10:26 p.m., Vinod Kone wrote: > > Can you attach the screenshot of the webui with these changes? Sure: index.html  offers.html  - Diogo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41891/#review112710 --- On Jan. 4, 2016, 10:23 p.m., Diogo Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41891/ > --- > > (Updated Jan. 4, 2016, 10:23 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3817 > https://issues.apache.org/jira/browse/MESOS-3817 > > > Repository: mesos > > > Description > --- > > Renaming offers to outstanding offers. > > > Diffs > - > > src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 > src/webui/master/static/offers.html > cc199352fcf2074dcd0e8d24bb49651b38c41d86 > > Diff: https://reviews.apache.org/r/41891/diff/ > > > Testing > --- > > Can be tested running Mesos Master web-ui front page and offers page (now > named as Outstanding Offers). Only html changed. > > > Thanks, > > Diogo Gomes > >
Re: Review Request 41891: Renaming offers to outstanding offers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41891/#review112710 --- Can you attach the screenshot of the webui with these changes? - Vinod Kone On Jan. 5, 2016, 12:23 a.m., Diogo Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41891/ > --- > > (Updated Jan. 5, 2016, 12:23 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3817 > https://issues.apache.org/jira/browse/MESOS-3817 > > > Repository: mesos > > > Description > --- > > Renaming offers to outstanding offers. > > > Diffs > - > > src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 > src/webui/master/static/offers.html > cc199352fcf2074dcd0e8d24bb49651b38c41d86 > > Diff: https://reviews.apache.org/r/41891/diff/ > > > Testing > --- > > Can be tested running Mesos Master web-ui front page and offers page (now > named as Outstanding Offers). Only html changed. > > > Thanks, > > Diogo Gomes > >
Re: Review Request 41891: Renaming offers to outstanding offers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41891/ --- (Updated Jan. 4, 2016, 10:23 p.m.) Review request for mesos and Vinod Kone. Summary (updated) - Renaming offers to outstanding offers. Bugs: MESOS-3817 https://issues.apache.org/jira/browse/MESOS-3817 Repository: mesos Description (updated) --- Renaming offers to outstanding offers. Diffs - src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 src/webui/master/static/offers.html cc199352fcf2074dcd0e8d24bb49651b38c41d86 Diff: https://reviews.apache.org/r/41891/diff/ Testing --- Can be tested running Mesos Master web-ui front page and offers page (now named as Outstanding Offers). Only html changed. Thanks, Diogo Gomes
Re: Review Request 41891: Renaming offers to outstanding offers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41891/#review112698 --- Bad patch! Reviews applied: [41891] Failed command: ./support/apply-review.sh -n -r 41891 Error: 2016-01-05 00:12:44 URL:https://reviews.apache.org/r/41891/diff/raw/ [1331/1331] -> "41891.patch" [1] No files to lint Error: Commit message summary (the first line) must end in a period. - Mesos ReviewBot On Jan. 4, 2016, 8:20 p.m., Diogo Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41891/ > --- > > (Updated Jan. 4, 2016, 8:20 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3817 > https://issues.apache.org/jira/browse/MESOS-3817 > > > Repository: mesos > > > Description > --- > > Renaming offers to outstanding offers > > > Diffs > - > > src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 > src/webui/master/static/offers.html > cc199352fcf2074dcd0e8d24bb49651b38c41d86 > > Diff: https://reviews.apache.org/r/41891/diff/ > > > Testing > --- > > Can be tested running Mesos Master web-ui front page and offers page (now > named as Outstanding Offers). Only html changed. > > > Thanks, > > Diogo Gomes > >
