Re: Review Request 41938: Cleaned up quota tests.

2016-01-15 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41938/#review114787
---

Ship it!


- Joris Van Remoortere


On Jan. 12, 2016, 9:33 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41938/
> ---
> 
> (Updated Jan. 12, 2016, 9:33 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changes made:
>   - removed extra ';' in resources string;
>   - renamed variables for clarity;
>   - updated comments;
>   - removed explicit conversion to `Resources`;
>   - wrapped test cases in {} blocks.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp 776a168254af6fa8a5d87d4580b35d83f2d5909a 
>   src/tests/registrar_tests.cpp 6064621a001d66423f9b2dc7b749b67d9fc4bc13 
> 
> Diff: https://reviews.apache.org/r/41938/diff/
> 
> 
> Testing
> ---
> 
> `make check` on Mac OS 10.10.5
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 41938: Cleaned up quota tests.

2016-01-13 Thread Bernd Mathiske 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41938/#review114203
---

Ship it!


Ship It!

- Bernd Mathiske


On Jan. 12, 2016, 1:33 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41938/
> ---
> 
> (Updated Jan. 12, 2016, 1:33 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changes made:
>   - removed extra ';' in resources string;
>   - renamed variables for clarity;
>   - updated comments;
>   - removed explicit conversion to `Resources`;
>   - wrapped test cases in {} blocks.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp 776a168254af6fa8a5d87d4580b35d83f2d5909a 
>   src/tests/registrar_tests.cpp 6064621a001d66423f9b2dc7b749b67d9fc4bc13 
> 
> Diff: https://reviews.apache.org/r/41938/diff/
> 
> 
> Testing
> ---
> 
> `make check` on Mac OS 10.10.5
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 41938: Cleaned up quota tests.

2016-01-12 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41938/
---

(Updated Jan. 12, 2016, 9:33 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Changes
---

Rebased; addressed Jörg's issues.


Repository: mesos


Description
---

Changes made:
  - removed extra ';' in resources string;
  - renamed variables for clarity;
  - updated comments;
  - removed explicit conversion to `Resources`;
  - wrapped test cases in {} blocks.


Diffs (updated)
-

  src/tests/master_quota_tests.cpp 776a168254af6fa8a5d87d4580b35d83f2d5909a 
  src/tests/registrar_tests.cpp 6064621a001d66423f9b2dc7b749b67d9fc4bc13 

Diff: https://reviews.apache.org/r/41938/diff/


Testing
---

`make check` on Mac OS 10.10.5


Thanks,

Alexander Rukletsov

Re: Review Request 41938: Cleaned up quota tests.

2016-01-06 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41938/#review113034
---



src/tests/master_quota_tests.cpp (line 160)


Shouldn't this be SetNonExistentRole?



src/tests/master_quota_tests.cpp (line 297)


SetResourcesSpecifyRole?


- Joerg Schad


On Jan. 5, 2016, 11:39 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41938/
> ---
> 
> (Updated Jan. 5, 2016, 11:39 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changes made:
>   - removed extra ';' in resources string;
>   - renamed variables for clarity;
>   - updated comments;
>   - removed explicit conversion to `Resources`;
>   - wrapped test cases in {} blocks.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33 
>   src/tests/registrar_tests.cpp 6064621a001d66423f9b2dc7b749b67d9fc4bc13 
> 
> Diff: https://reviews.apache.org/r/41938/diff/
> 
> 
> Testing
> ---
> 
> `make check` on Mac OS 10.10.5
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 41938: Cleaned up quota tests.

2016-01-05 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41938/
---

(Updated Jan. 5, 2016, 11:39 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Changes
---

Cleaned up registrar tests as well.


Repository: mesos


Description
---

Changes made:
  - removed extra ';' in resources string;
  - renamed variables for clarity;
  - updated comments;
  - removed explicit conversion to `Resources`;
  - wrapped test cases in {} blocks.


Diffs (updated)
-

  src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33 
  src/tests/registrar_tests.cpp 6064621a001d66423f9b2dc7b749b67d9fc4bc13 

Diff: https://reviews.apache.org/r/41938/diff/


Testing
---

`make check` on Mac OS 10.10.5


Thanks,

Alexander Rukletsov