Re: Review Request 42011: Added gtest flags to generate xml report.

2016-01-08 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/#review113536
---

Ship it!


Thank you! This is very helpful to the project. We'll get this committed 
shortly.


support/docker_build.sh (line 70)


I'll add a period here.


- Ben Mahler


On Jan. 7, 2016, 1:55 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42011/
> ---
> 
> (Updated Jan. 7, 2016, 1:55 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added gtest flags to generate xml report.
> 
> 
> Diffs
> -
> 
>   Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
>   support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 
> 
> Diff: https://reviews.apache.org/r/42011/diff/
> 
> 
> Testing
> ---
> 
> $ export GTEST_OUTPUT=xml:report.xml
> $ make check
> $ find . -name report.xml 
>   
>  
> ./3rdparty/libprocess/report.xml
> ./3rdparty/libprocess/3rdparty/report.xml
> ./src/report.xml
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42011: Added gtest flags to generate xml report.

2016-01-07 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/
---

(Updated Jan. 7, 2016, 1:55 p.m.)


Review request for mesos, Ben Mahler and haosdent huang.


Summary (updated)
-

Added gtest flags to generate xml report.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Added gtest flags to generate xml report.


Diffs
-

  Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
  support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 

Diff: https://reviews.apache.org/r/42011/diff/


Testing
---

$ export GTEST_OUTPUT=xml:report.xml
$ make check
$ find . -name report.xml   
 
./3rdparty/libprocess/report.xml
./3rdparty/libprocess/3rdparty/report.xml
./src/report.xml


Thanks,

Shuai Lin

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-07 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/#review113250
---


Bad patch!

Reviews applied: [42011]

Failed command: ./support/apply-review.sh -n -r 42011

Error:
 2016-01-07 12:50:16 URL:https://reviews.apache.org/r/42011/diff/raw/ [995/995] 
-> "42011.patch" [1]
No files to lint

Error: Commit message summary (the first line) must end in a period.

- Mesos ReviewBot


On Jan. 7, 2016, 12:37 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42011/
> ---
> 
> (Updated Jan. 7, 2016, 12:37 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added gtest flags to generate xml report.
> 
> 
> Diffs
> -
> 
>   Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
>   support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 
> 
> Diff: https://reviews.apache.org/r/42011/diff/
> 
> 
> Testing
> ---
> 
> $ export GTEST_OUTPUT=xml:report.xml
> $ make check
> $ find . -name report.xml 
>   
>  
> ./3rdparty/libprocess/report.xml
> ./3rdparty/libprocess/3rdparty/report.xml
> ./src/report.xml
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-07 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/#review113239
---


Bad patch!

Reviews applied: [42011]

Failed command: ./support/apply-review.sh -n -r 42011

Error:
 2016-01-07 11:39:58 URL:https://reviews.apache.org/r/42011/diff/raw/ [995/995] 
-> "42011.patch" [1]
No files to lint

Error: Commit message summary (the first line) must end in a period.

- Mesos ReviewBot


On Jan. 7, 2016, 5:34 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42011/
> ---
> 
> (Updated Jan. 7, 2016, 5:34 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added gtest flags to generate xml report
> 
> 
> Diffs
> -
> 
>   Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
>   support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 
> 
> Diff: https://reviews.apache.org/r/42011/diff/
> 
> 
> Testing
> ---
> 
> $ export GTEST_OUTPUT=xml:report.xml
> $ make check
> $ find . -name report.xml 
>   
>  
> ./3rdparty/libprocess/report.xml
> ./3rdparty/libprocess/3rdparty/report.xml
> ./src/report.xml
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread Shuai Lin 


> On Jan. 7, 2016, 3:39 a.m., Anand Mazumdar wrote:
> > support/docker_build.sh, line 69
> > 
> >
> > Nit: Newline before this line.
> > 
> > Also can you add a comment before this line like we have for other 
> > lines:
> > 
> > # Generate XML test report.

thanks, fixed!


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/#review113178
---


On Jan. 7, 2016, 2:44 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42011/
> ---
> 
> (Updated Jan. 7, 2016, 2:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added gtest flags to generate xml report
> 
> 
> Diffs
> -
> 
>   Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
>   support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 
> 
> Diff: https://reviews.apache.org/r/42011/diff/
> 
> 
> Testing
> ---
> 
> $ export GTEST_OUTPUT=xml:report.xml
> $ make check
> $ find . -name report.xml 
>   
>  
> ./3rdparty/libprocess/report.xml
> ./3rdparty/libprocess/3rdparty/report.xml
> ./src/report.xml
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/
---

(Updated Jan. 7, 2016, 5:34 a.m.)


Review request for mesos, Ben Mahler and haosdent huang.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Added gtest flags to generate xml report


Diffs (updated)
-

  Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
  support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 

Diff: https://reviews.apache.org/r/42011/diff/


Testing
---

$ export GTEST_OUTPUT=xml:report.xml
$ make check
$ find . -name report.xml   
 
./3rdparty/libprocess/report.xml
./3rdparty/libprocess/3rdparty/report.xml
./src/report.xml


Thanks,

Shuai Lin

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/#review113178
---

Ship it!


LGTM.

Can you also find a shepherd for this by mailing on dev@ and update the JIRA 
thereafter ?


support/docker_build.sh (line 69)


Nit: Newline before this line.

Also can you add a comment before this line like we have for other lines:

# Generate XML test report.


- Anand Mazumdar


On Jan. 7, 2016, 2:44 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42011/
> ---
> 
> (Updated Jan. 7, 2016, 2:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added gtest flags to generate xml report
> 
> 
> Diffs
> -
> 
>   Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
>   support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 
> 
> Diff: https://reviews.apache.org/r/42011/diff/
> 
> 
> Testing
> ---
> 
> $ export GTEST_OUTPUT=xml:report.xml
> $ make check
> $ find . -name report.xml 
>   
>  
> ./3rdparty/libprocess/report.xml
> ./3rdparty/libprocess/3rdparty/report.xml
> ./src/report.xml
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/
---

(Updated Jan. 7, 2016, 2:44 a.m.)


Review request for mesos, Ben Mahler and haosdent huang.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Added gtest flags to generate xml report


Diffs
-

  Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
  support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 

Diff: https://reviews.apache.org/r/42011/diff/


Testing (updated)
---

$ export GTEST_OUTPUT=xml:report.xml
$ make check
$ find . -name report.xml   
 
./3rdparty/libprocess/report.xml
./3rdparty/libprocess/3rdparty/report.xml
./src/report.xml


Thanks,

Shuai Lin

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/#review113173
---

Ship it!


Ship It!

- haosdent huang


On Jan. 7, 2016, 2:39 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42011/
> ---
> 
> (Updated Jan. 7, 2016, 2:39 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added gtest flags to generate xml report
> 
> 
> Diffs
> -
> 
>   Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
>   support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 
> 
> Diff: https://reviews.apache.org/r/42011/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread Shuai Lin 


> On Jan. 7, 2016, 2:17 a.m., haosdent huang wrote:
> > support/docker_build.sh, line 69
> > 
> >
> > do here overwrite the env `GTEST_FILTER` before?
> 
> haosdent huang wrote:
> Seems would overwrite according my test.
> 
> Shuai Lin wrote:
> Sorry, it's a typo. Already updated.


root@hostname ~/dev/mesos/mesos-master-branch/build # find . -name report.xml   

 
./3rdparty/libprocess/report.xml
./3rdparty/libprocess/3rdparty/report.xml
./src/report.xml



- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/#review113167
---


On Jan. 7, 2016, 2:39 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42011/
> ---
> 
> (Updated Jan. 7, 2016, 2:39 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added gtest flags to generate xml report
> 
> 
> Diffs
> -
> 
>   Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
>   support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 
> 
> Diff: https://reviews.apache.org/r/42011/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread Shuai Lin 


> On Jan. 7, 2016, 2:17 a.m., haosdent huang wrote:
> > support/docker_build.sh, line 69
> > 
> >
> > do here overwrite the env `GTEST_FILTER` before?
> 
> haosdent huang wrote:
> Seems would overwrite according my test.

Sorry, it's a typo. Already updated.


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/#review113167
---


On Jan. 7, 2016, 2:39 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42011/
> ---
> 
> (Updated Jan. 7, 2016, 2:39 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added gtest flags to generate xml report
> 
> 
> Diffs
> -
> 
>   Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
>   support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 
> 
> Diff: https://reviews.apache.org/r/42011/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/
---

(Updated Jan. 7, 2016, 2:39 a.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Added gtest flags to generate xml report


Diffs (updated)
-

  Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
  support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 

Diff: https://reviews.apache.org/r/42011/diff/


Testing
---

make check


Thanks,

Shuai Lin

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread haosdent huang 


> On Jan. 7, 2016, 2:17 a.m., haosdent huang wrote:
> > support/docker_build.sh, line 69
> > 
> >
> > do here overwrite the env `GTEST_FILTER` before?

Seems would overwrite according my test.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/#review113167
---


On Jan. 7, 2016, 1:40 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42011/
> ---
> 
> (Updated Jan. 7, 2016, 1:40 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added gtest flags to generate xml report
> 
> 
> Diffs
> -
> 
>   Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
>   support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 
> 
> Diff: https://reviews.apache.org/r/42011/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/#review113167
---



support/docker_build.sh (line 69)


do here overwrite the env `GTEST_FILTER` before?


- haosdent huang


On Jan. 7, 2016, 1:40 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42011/
> ---
> 
> (Updated Jan. 7, 2016, 1:40 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added gtest flags to generate xml report
> 
> 
> Diffs
> -
> 
>   Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
>   support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 
> 
> Diff: https://reviews.apache.org/r/42011/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>