Re: Review Request 42273: Modified scheduler library to move the queue contents before `async`.

2016-01-14 Thread Anand Mazumdar
> On Jan. 14, 2016, 9:03 a.m., Benjamin Bannier wrote: > > Was the decision to optimize here driven by profiling? > > > > Given the proposed implementation I wonder if this was worth the risk. I > > can only see this being called for single element `queues` of `Events` > > which should not be

Re: Review Request 42273: Modified scheduler library to move the queue contents before `async`.

2016-01-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42273/#review114440 --- src/scheduler/scheduler.cpp (line 261)

Re: Review Request 42273: Modified scheduler library to move the queue contents before `async`.

2016-01-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42273/#review114441 --- Was the decision to optimize here driven by profiling? Given the

Re: Review Request 42273: Modified scheduler library to move the queue contents before `async`.

2016-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42273/#review114426 --- Patch looks great! Reviews applied: [42273] Passed command:

Re: Review Request 42273: Modified scheduler library to move the queue contents before `async`.

2016-01-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42273/#review114390 --- Ship it! Ship It! - Guangya Liu On 一月 13, 2016, 11:06 p.m.,