Re: Review Request 42309: Fallback to --git-dir when --git-common-dir not available.

2016-01-14 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42309/#review114629 --- Ship it! Thanks for promptly following up on this issue, Kevin!

Re: Review Request 42309: Fallback to --git-dir when --git-common-dir not available.

2016-01-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42309/ --- (Updated Jan. 15, 2016, 1:04 a.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 42309: Fallback to --git-dir when --git-common-dir not available.

2016-01-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42309/#review114575 --- Patch looks great! Reviews applied: [42309] Passed command: expor

Re: Review Request 42309: Fallback to --git-dir when --git-common-dir not available.

2016-01-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42309/#review114553 --- Ship it! Tested with git-2.7.0 (OS X 10.10.5) and git-2.1.4 (Debia

Re: Review Request 42309: Fallback to --git-dir when --git-common-dir not available.

2016-01-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42309/ --- (Updated Jan. 14, 2016, 7:56 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 42309: Fallback to --git-dir when --git-common-dir not available.

2016-01-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42309/#review114526 --- bootstrap (line 35)

Re: Review Request 42309: Fallback to --git-dir when --git-common-dir not available.

2016-01-14 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42309/#review114517 --- Ship it! Ship It! - haosdent huang On Jan. 14, 2016, 5:56 p.m.,

Re: Review Request 42309: Fallback to --git-dir when --git-common-dir not available.

2016-01-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42309/ --- (Updated Jan. 14, 2016, 5:56 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 42309: Fallback to --git-dir when --git-common-dir not available.

2016-01-14 Thread haosdent huang
> On Jan. 14, 2016, 5:26 p.m., haosdent huang wrote: > > support/post-reviews.py, line 98 > > > > > > Pull to else seems would be better? > > Kevin Klues wrote: > I'm sorry, I don't understand your comment. I ne

Re: Review Request 42309: Fallback to --git-dir when --git-common-dir not available.

2016-01-14 Thread Kevin Klues
> On Jan. 14, 2016, 5:26 p.m., haosdent huang wrote: > > support/post-reviews.py, line 98 > > > > > > Pull to else seems would be better? I'm sorry, I don't understand your comment. I need to first try the call with

Re: Review Request 42309: Fallback to --git-dir when --git-common-dir not available.

2016-01-14 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42309/#review114502 --- support/post-reviews.py (line 98)