Re: Review Request 42557: Moved CachedImage to a separate file.

2016-02-04 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42557/#review117874
---


Ship it!




Ship It!

- Jie Yu


On Feb. 4, 2016, 2:53 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42557/
> ---
> 
> (Updated Feb. 4, 2016, 2:53 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently CachedImage is private to the appc store. This will change as we
> implement image fetchers (eg. simple discovery).
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0 
>   src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
>   src/slave/containerizer/mesos/provisioner/appc/cache.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/cache.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 73c4df858a70da3d4cc4a1cb15092165f6ff8fe4 
> 
> Diff: https://reviews.apache.org/r/42557/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 42557: Moved CachedImage to a separate file.

2016-02-03 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42557/
---

(Updated Feb. 4, 2016, 2:53 a.m.)


Review request for mesos and Jie Yu.


Changes
---

review addressed.


Repository: mesos


Description (updated)
---

Currently CachedImage is private to the appc store. This will change as we
implement image fetchers (eg. simple discovery).


Diffs (updated)
-

  src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0 
  src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
  src/slave/containerizer/mesos/provisioner/appc/cache.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/cache.cpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
73c4df858a70da3d4cc4a1cb15092165f6ff8fe4 

Diff: https://reviews.apache.org/r/42557/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 42557: Moved CachedImage to a separate file.

2016-02-03 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42557/#review117671
---




src/CMakeLists.txt (line 239)


Did you forget to update this patch. I saw it becomes cache.cpp in later 
patches.



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 172)


Hum, we don't usually sneak in changes like this in a 'move' patch. It'll 
be very to hard to review. Can you separate this change into a separate patch?


- Jie Yu


On Jan. 30, 2016, 2:06 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42557/
> ---
> 
> (Updated Jan. 30, 2016, 2:06 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently CachedImage is private to the appc store. This will change as we
> implement image fetchers (eg. simple discovery).
> 
> This change will enable image fetcher to use the same structure.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0 
>   src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
>   src/slave/containerizer/mesos/provisioner/appc/image_cache.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/image_cache.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 73c4df858a70da3d4cc4a1cb15092165f6ff8fe4 
> 
> Diff: https://reviews.apache.org/r/42557/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 42557: Moved CachedImage to a separate file.

2016-01-29 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42557/
---

(Updated Jan. 30, 2016, 2:06 a.m.)


Review request for mesos and Jie Yu.


Changes
---

rebased


Repository: mesos


Description
---

Currently CachedImage is private to the appc store. This will change as we
implement image fetchers (eg. simple discovery).

This change will enable image fetcher to use the same structure.


Diffs (updated)
-

  src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0 
  src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
  src/slave/containerizer/mesos/provisioner/appc/image_cache.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/image_cache.cpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
73c4df858a70da3d4cc4a1cb15092165f6ff8fe4 

Diff: https://reviews.apache.org/r/42557/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 42557: Moved CachedImage to a separate file.

2016-01-22 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42557/#review115817
---


Patch looks great!

Reviews applied: [41958, 41959, 42156, 42157, 42274, 42554, 42557]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 22, 2016, 6:52 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42557/
> ---
> 
> (Updated Jan. 22, 2016, 6:52 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently CachedImage is private to the appc store. This will change as we
> implement image fetchers (eg. simple discovery).
> 
> This change will enable image fetcher to use the same structure.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 47d0a7c0fe73b9297cd7dde6086b5e6e9e1f9e4e 
>   src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f 
>   src/slave/containerizer/mesos/provisioner/appc/image_cache.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/image_cache.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 73c4df858a70da3d4cc4a1cb15092165f6ff8fe4 
> 
> Diff: https://reviews.apache.org/r/42557/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 42557: Moved CachedImage to a separate file.

2016-01-21 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42557/
---

(Updated Jan. 22, 2016, 6:52 a.m.)


Review request for mesos and Jie Yu.


Changes
---

rebased


Repository: mesos


Description
---

Currently CachedImage is private to the appc store. This will change as we
implement image fetchers (eg. simple discovery).

This change will enable image fetcher to use the same structure.


Diffs (updated)
-

  src/CMakeLists.txt 47d0a7c0fe73b9297cd7dde6086b5e6e9e1f9e4e 
  src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f 
  src/slave/containerizer/mesos/provisioner/appc/image_cache.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/image_cache.cpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
73c4df858a70da3d4cc4a1cb15092165f6ff8fe4 

Diff: https://reviews.apache.org/r/42557/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 42557: Moved CachedImage to a separate file.

2016-01-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42557/#review115465
---


Bad patch!

Reviews applied: [41958, 41959, 42156, 42157]

Failed command: ./support/apply-review.sh -n -r 42157

Error:
 2016-01-20 19:44:16 URL:https://reviews.apache.org/r/42157/diff/raw/ 
[3978/3978] -> "42157.patch" [1]
error: patch failed: src/tests/containerizer/provisioner_appc_tests.cpp:253
error: src/tests/containerizer/provisioner_appc_tests.cpp: patch does not apply

- Mesos ReviewBot


On Jan. 20, 2016, 4:16 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42557/
> ---
> 
> (Updated Jan. 20, 2016, 4:16 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently CachedImage is private to the appc store. This will change as we
> implement image fetchers (eg. simple discovery).
> 
> This change will enable image fetcher to use the same structure.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
>   src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
>   src/slave/containerizer/mesos/provisioner/appc/image_cache.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/image_cache.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 73c4df858a70da3d4cc4a1cb15092165f6ff8fe4 
> 
> Diff: https://reviews.apache.org/r/42557/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>