Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

2016-02-24 Thread Cong Wang
> On Feb. 24, 2016, 7:29 p.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/future.hpp, line 791 > > > > > > * Mesos currently uses `foreach` from stout rather than > > range-based`for`. > > * Mes

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

2016-02-24 Thread Michael Park
> On Feb. 24, 2016, 7:29 p.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/future.hpp, line 791 > > > > > > * Mesos currently uses `foreach` from stout rather than > > range-based`for`. > > * Mes

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

2016-02-24 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43461/#review120564 --- 3rdparty/libprocess/include/process/future.hpp (line 791)

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

2016-02-24 Thread Michael Park
> On Feb. 24, 2016, 7:30 p.m., Vinod Kone wrote: > > LGTM. Though I'm not sure why we used iterators instead of foreach in the > > first place. cc @mcypark Because it was written before `foreach` was introduced to stout. The last of the `for` loops here was authored 2011-10-31 and `foreach` wa

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

2016-02-24 Thread Cong Wang
> On Feb. 24, 2016, 7:29 p.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/future.hpp, line 791 > > > > > > * Mesos currently uses `foreach` from stout rather than > > range-based`for`. > > * Mes

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

2016-02-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43461/#review120552 --- Ship it! LGTM. Though I'm not sure why we used iterators instea

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

2016-02-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43461/#review120550 --- Thanks for the cleanup! 3rdparty/libprocess/include/process/futu

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

2016-02-24 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43461/ --- (Updated Feb. 24, 2016, 7:19 p.m.) Review request for mesos, Ben Mahler, Ian Do

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

2016-02-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43461/#review118809 --- Patch looks great! Reviews applied: [43461] Passed command: expo