Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/#review120942 --- Ship it! Ship It! - Jie Yu On Feb. 26, 2016, 4:58 p.m., Greg

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/#review120919 --- Ship it! Ship It! - Neil Conway On Feb. 26, 2016, 4:58 p.m.,

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-26 Thread Greg Mann
> On Feb. 26, 2016, 5:42 a.m., Neil Conway wrote: > > src/tests/reservation_endpoints_tests.cpp, line 1273 > > > > > > The analogous test for volumes names these variables differently > > (`volume1`, `volume2`, and

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/ --- (Updated Feb. 26, 2016, 4:58 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/#review120829 --- src/tests/reservation_endpoints_tests.cpp (line 1069)

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/ --- (Updated Feb. 26, 2016, 5:31 a.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-24 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/ --- (Updated Feb. 24, 2016, 6:42 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/ --- (Updated Feb. 22, 2016, 7:58 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/#review120033 --- src/tests/reservation_endpoints_tests.cpp (line 1035)