Re: Review Request 43932: Added overlayfs provisioning backend.

2016-07-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43932/#review141566 --- Closing this review due to inactivity. Please see our

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-28 Thread Shuai Lin
> On Feb. 25, 2016, 11:40 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, lines > > 124-129 > > > > > > To be safe, can you do the same thing to mark the mount as

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43932/#review121158 --- Patch looks great! Reviews applied: [43718, 43932] Passed

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-28 Thread Jie Yu
> On Feb. 25, 2016, 11:40 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, lines > > 124-129 > > > > > > To be safe, can you do the same thing to mark the mount as

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-28 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43932/ --- (Updated Feb. 28, 2016, 5:22 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-28 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43932/ --- (Updated Feb. 28, 2016, 5:17 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-28 Thread Shuai Lin
> On Feb. 25, 2016, 11:40 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.hpp, lines 30-31 > > > > > > can you wrap comments in 70 char width. It's less jagged IMO. done > On

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43932/#review120750 --- Fix it, then Ship it! Thanks! This is great!

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-24 Thread Cong Wang
> On Feb. 25, 2016, 2:52 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, line 106 > > > > > > just a question, does there are any policy when to use `Failure` and > >

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43932/#review120649 --- src/slave/containerizer/mesos/provisioner/backend.cpp (lines 23

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43932/#review120540 --- Patch looks great! Reviews applied: [43718, 43932] Passed