Re: Review Request 43985: Windows: [1/4] Implemented `sendfile`.

2016-04-22 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43985/#review130044
---


Ship it!




Committed with the following changes.


3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp (line 16)


Remove newline.



3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 


Add newline.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp (line 
51)


`s/return SocketError();/  return SocketError();/`



3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (lines 119 - 
121)


Remove this.


- Michael Park


On April 21, 2016, 6:31 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43985/
> ---
> 
> (Updated April 21, 2016, 6:31 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: [1/4] Implemented `sendfile`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
> cd1bad14919b9d566d5201201d8c3b4a335d5b9f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 
> 293f82f6730551491504721e0af28e9537540db1 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 
> f3197679a9c22b37acae003262e5c6d21e110f56 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp 
> 750ca6749cb028703ed2fb5dec2aac6c5dabea0d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 3828c53c0dbbf370d642189998af75b9af434e9d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp 
> d634491b301632ce6468f86d04f21fa25afbbaaa 
> 
> Diff: https://reviews.apache.org/r/43985/diff/
> 
> 
> Testing
> ---
> 
> Build Windows,
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 43985: Windows: [1/4] Implemented `sendfile`.

2016-04-21 Thread Daniel Pravat 


> On April 21, 2016, 2:08 a.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp, 
> > line 38
> > 
> >
> > Where did the `& MAXDWORD` come from, and why?

This is for clarity. In any case this will go away.


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43985/#review129828
---


On April 21, 2016, 6:31 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43985/
> ---
> 
> (Updated April 21, 2016, 6:31 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: [1/4] Implemented `sendfile`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
> cd1bad14919b9d566d5201201d8c3b4a335d5b9f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 
> 293f82f6730551491504721e0af28e9537540db1 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 
> f3197679a9c22b37acae003262e5c6d21e110f56 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp 
> 750ca6749cb028703ed2fb5dec2aac6c5dabea0d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 3828c53c0dbbf370d642189998af75b9af434e9d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp 
> d634491b301632ce6468f86d04f21fa25afbbaaa 
> 
> Diff: https://reviews.apache.org/r/43985/diff/
> 
> 
> Testing
> ---
> 
> Build Windows,
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 43985: Windows: [1/4] Implemented `sendfile`.

2016-04-21 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43985/
---

(Updated April 21, 2016, 6:31 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Windows: [1/4] Implemented `sendfile`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
cd1bad14919b9d566d5201201d8c3b4a335d5b9f 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 
293f82f6730551491504721e0af28e9537540db1 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 
f3197679a9c22b37acae003262e5c6d21e110f56 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp 
750ca6749cb028703ed2fb5dec2aac6c5dabea0d 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
3828c53c0dbbf370d642189998af75b9af434e9d 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp 
d634491b301632ce6468f86d04f21fa25afbbaaa 

Diff: https://reviews.apache.org/r/43985/diff/


Testing
---

Build Windows,
OSX: make check


Thanks,

Daniel Pravat

Re: Review Request 43985: Windows: [1/4] Implemented `sendfile`.

2016-04-20 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43985/#review129828
---




3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp (lines 25 - 29)


Let's keep these separate. They're indepedent blocks with independent 
semantics.

```
#ifdef __WINDOWS__
#include 
#endif  // __WINDOWS__

using SocketError =
#ifdef __WINDOWS_
  WindowsSocketError;
#else
  ErrnoError;
#endif  // __WINDOWS__
```



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp (line 37)


Backticks around `Try`, and `ErrnoError` should be 
`SocketError`.



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp (line 64)


By "Here and below", I mean these should have also be updated to `return 
SocketError();`.



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp (line 76)


By "Here and below", I mean these should have also be updated to `return 
SocketError();`.



3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 


Please add this back.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp (line 
35)


Where did the `& MAXDWORD` come from, and why?



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp (line 
43)


I requested to return `SocketError` here, it's marked as resolved but it 
doesn't seem so.



3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (lines 119 - 
121)





- Michael Park


On April 20, 2016, 4:45 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43985/
> ---
> 
> (Updated April 20, 2016, 4:45 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: [1/4] Implemented `sendfile`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
> cd1bad14919b9d566d5201201d8c3b4a335d5b9f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 
> 293f82f6730551491504721e0af28e9537540db1 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 
> f3197679a9c22b37acae003262e5c6d21e110f56 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp 
> 750ca6749cb028703ed2fb5dec2aac6c5dabea0d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> a7f855dc9d0a87fe3b6d1611e7ae22e4d7cd7b6d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp 
> d634491b301632ce6468f86d04f21fa25afbbaaa 
> 
> Diff: https://reviews.apache.org/r/43985/diff/
> 
> 
> Testing
> ---
> 
> Build Windows,
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 43985: Windows: [1/4] Implemented `sendfile`.

2016-04-20 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43985/
---

(Updated April 20, 2016, 4:45 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Summary (updated)
-

Windows: [1/4] Implemented `sendfile`.


Repository: mesos


Description (updated)
---

Windows: [1/4] Implemented `sendfile`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
cd1bad14919b9d566d5201201d8c3b4a335d5b9f 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 
293f82f6730551491504721e0af28e9537540db1 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 
f3197679a9c22b37acae003262e5c6d21e110f56 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp 
750ca6749cb028703ed2fb5dec2aac6c5dabea0d 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
a7f855dc9d0a87fe3b6d1611e7ae22e4d7cd7b6d 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp 
d634491b301632ce6468f86d04f21fa25afbbaaa 

Diff: https://reviews.apache.org/r/43985/diff/


Testing (updated)
---

Build Windows,
OSX: make check


Thanks,

Daniel Pravat