Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/#review123211
---


Ship it!




Ship It!

- Vinod Kone


On March 11, 2016, 1:47 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44320/
> ---
> 
> (Updated March 11, 2016, 1:47 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first step towards separating the language used to define
> the ACLs from the mechanism to query them.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.hpp PRE-CREATION 
>   include/mesos/authorizer/authorizer.hpp 
> 705482656788ac12e9d21e355b71fd2ede2be558 
>   include/mesos/authorizer/authorizer.proto 
> d65377c6c4ed9364efdc531b885c1a8af962ec34 
>   src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/authorizer/acls.cpp PRE-CREATION 
>   src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
>   src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
>   src/examples/persistent_volume_framework.cpp 
> 4218b1563e10aaefe9abcdc20c90c13651959790 
>   src/examples/test_authorizer_module.cpp 
> 95d77fbff0cdfdb360a8597fbba28404b59d0042 
>   src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
>   src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
> 
> Diff: https://reviews.apache.org/r/44320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/
---

(Updated March 11, 2016, 2:47 p.m.)


Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.


Changes
---

Added TODO.


Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950


Repository: mesos


Description
---

This is the first step towards separating the language used to define
the ACLs from the mechanism to query them.


Diffs (updated)
-

  include/mesos/authorizer/acls.hpp PRE-CREATION 
  include/mesos/authorizer/authorizer.hpp 
705482656788ac12e9d21e355b71fd2ede2be558 
  include/mesos/authorizer/authorizer.proto 
d65377c6c4ed9364efdc531b885c1a8af962ec34 
  src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
  src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
  src/authorizer/acls.cpp PRE-CREATION 
  src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
  src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
  src/examples/persistent_volume_framework.cpp 
4218b1563e10aaefe9abcdc20c90c13651959790 
  src/examples/test_authorizer_module.cpp 
95d77fbff0cdfdb360a8597fbba28404b59d0042 
  src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
  src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 

Diff: https://reviews.apache.org/r/44320/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Alexander Rojas]

> On March 10, 2016, 10:06 p.m., Vinod Kone wrote:
> > src/Makefile.am, line 158
> > 
> >
> > any reason why this should be exposed in the include directory?
> 
> Alexander Rojas wrote:
> Main reason is because of this `static Try 
> mesos::Authorizer::create(const ACLs& acls);` which is already part of the 
> public API, although it can be forward declared there (It is, actually).
> 
> But it is mentioned in the public API so I thought it should go there 
> anyway.

Moreover, in this patch we have not yet change the signature of the 
`Authorizer`, so every method requires as a parameter one of the `ACL` sub 
messages (whichcannot be forward declared because `ACL` is not a namespace).

This however can be done in a later patch.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/#review122988
---


On March 10, 2016, 3:09 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44320/
> ---
> 
> (Updated March 10, 2016, 3:09 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first step towards separating the language used to define
> the ACLs from the mechanism to query them.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.hpp PRE-CREATION 
>   include/mesos/authorizer/authorizer.hpp 
> 705482656788ac12e9d21e355b71fd2ede2be558 
>   include/mesos/authorizer/authorizer.proto  
>   src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/authorizer/acls.cpp PRE-CREATION 
>   src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
>   src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
>   src/examples/persistent_volume_framework.cpp 
> 4218b1563e10aaefe9abcdc20c90c13651959790 
>   src/examples/test_authorizer_module.cpp 
> 95d77fbff0cdfdb360a8597fbba28404b59d0042 
>   src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
>   src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
> 
> Diff: https://reviews.apache.org/r/44320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Alexander Rojas]

> On March 10, 2016, 10:06 p.m., Vinod Kone wrote:
> > src/Makefile.am, line 158
> > 
> >
> > any reason why this should be exposed in the include directory?

Main reason is because of this `static Try 
mesos::Authorizer::create(const ACLs& acls);` which is already part of the 
public API, although it can be forward declared there (It is, actually).

But it is mentioned in the public API so I thought it should go there anyway.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/#review122988
---


On March 10, 2016, 3:09 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44320/
> ---
> 
> (Updated March 10, 2016, 3:09 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first step towards separating the language used to define
> the ACLs from the mechanism to query them.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.hpp PRE-CREATION 
>   include/mesos/authorizer/authorizer.hpp 
> 705482656788ac12e9d21e355b71fd2ede2be558 
>   include/mesos/authorizer/authorizer.proto  
>   src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/authorizer/acls.cpp PRE-CREATION 
>   src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
>   src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
>   src/examples/persistent_volume_framework.cpp 
> 4218b1563e10aaefe9abcdc20c90c13651959790 
>   src/examples/test_authorizer_module.cpp 
> 95d77fbff0cdfdb360a8597fbba28404b59d0042 
>   src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
>   src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
> 
> Diff: https://reviews.apache.org/r/44320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/#review122988
---




src/Makefile.am (line 158)


any reason why this should be exposed in the include directory?


- Vinod Kone


On March 10, 2016, 2:09 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44320/
> ---
> 
> (Updated March 10, 2016, 2:09 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first step towards separating the language used to define
> the ACLs from the mechanism to query them.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.hpp PRE-CREATION 
>   include/mesos/authorizer/authorizer.hpp 
> 705482656788ac12e9d21e355b71fd2ede2be558 
>   include/mesos/authorizer/authorizer.proto  
>   src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/authorizer/acls.cpp PRE-CREATION 
>   src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
>   src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
>   src/examples/persistent_volume_framework.cpp 
> 4218b1563e10aaefe9abcdc20c90c13651959790 
>   src/examples/test_authorizer_module.cpp 
> 95d77fbff0cdfdb360a8597fbba28404b59d0042 
>   src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
>   src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
> 
> Diff: https://reviews.apache.org/r/44320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/
---

(Updated March 10, 2016, 3:09 p.m.)


Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.


Changes
---

Adresses adam's review.


Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950


Repository: mesos


Description
---

This is the first step towards separating the language used to define
the ACLs from the mechanism to query them.


Diffs (updated)
-

  include/mesos/authorizer/acls.hpp PRE-CREATION 
  include/mesos/authorizer/authorizer.hpp 
705482656788ac12e9d21e355b71fd2ede2be558 
  include/mesos/authorizer/authorizer.proto  
  src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
  src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
  src/authorizer/acls.cpp PRE-CREATION 
  src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
  src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
  src/examples/persistent_volume_framework.cpp 
4218b1563e10aaefe9abcdc20c90c13651959790 
  src/examples/test_authorizer_module.cpp 
95d77fbff0cdfdb360a8597fbba28404b59d0042 
  src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
  src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 

Diff: https://reviews.apache.org/r/44320/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Alexander Rojas]

> On March 10, 2016, 10:14 a.m., Adam B wrote:
> > src/authorizer/authorizer.cpp, lines 43-44
> > 
> >
> > Double-blank line between impls, please

screw up while rebasing.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/#review122902
---


On March 9, 2016, 3:07 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44320/
> ---
> 
> (Updated March 9, 2016, 3:07 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first step towards separating the language used to define
> the ACLs from the mechanism to query them.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.hpp PRE-CREATION 
>   include/mesos/authorizer/authorizer.hpp 
> 705482656788ac12e9d21e355b71fd2ede2be558 
>   include/mesos/authorizer/authorizer.proto  
>   src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/authorizer/acls.cpp PRE-CREATION 
>   src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
>   src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
>   src/examples/persistent_volume_framework.cpp 
> 4218b1563e10aaefe9abcdc20c90c13651959790 
>   src/examples/test_authorizer_module.cpp 
> 95d77fbff0cdfdb360a8597fbba28404b59d0042 
>   src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
>   src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
> 
> Diff: https://reviews.apache.org/r/44320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/#review122902
---


Fix it, then Ship it!




Looks good. Just some alpha-order nits, mostly.


src/CMakeLists.txt (lines 24 - 26)


re-alphabetize



src/CMakeLists.txt (lines 56 - 58)


re-alphabetize



src/Makefile.am (lines 409 - 411)


re-alphabetize



src/authorizer/authorizer.cpp (line 41)


Double-blank line between impls, please


- Adam B


On March 9, 2016, 6:07 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44320/
> ---
> 
> (Updated March 9, 2016, 6:07 a.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first step towards separating the language used to define
> the ACLs from the mechanism to query them.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.hpp PRE-CREATION 
>   include/mesos/authorizer/authorizer.hpp 
> 705482656788ac12e9d21e355b71fd2ede2be558 
>   include/mesos/authorizer/authorizer.proto  
>   src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/authorizer/acls.cpp PRE-CREATION 
>   src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
>   src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
>   src/examples/persistent_volume_framework.cpp 
> 4218b1563e10aaefe9abcdc20c90c13651959790 
>   src/examples/test_authorizer_module.cpp 
> 95d77fbff0cdfdb360a8597fbba28404b59d0042 
>   src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
>   src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
> 
> Diff: https://reviews.apache.org/r/44320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/
---

(Updated March 9, 2016, 3:07 p.m.)


Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950


Repository: mesos


Description
---

This is the first step towards separating the language used to define
the ACLs from the mechanism to query them.


Diffs (updated)
-

  include/mesos/authorizer/acls.hpp PRE-CREATION 
  include/mesos/authorizer/authorizer.hpp 
705482656788ac12e9d21e355b71fd2ede2be558 
  include/mesos/authorizer/authorizer.proto  
  src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
  src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
  src/authorizer/acls.cpp PRE-CREATION 
  src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
  src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
  src/examples/persistent_volume_framework.cpp 
4218b1563e10aaefe9abcdc20c90c13651959790 
  src/examples/test_authorizer_module.cpp 
95d77fbff0cdfdb360a8597fbba28404b59d0042 
  src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
  src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 

Diff: https://reviews.apache.org/r/44320/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/
---

(Updated March 9, 2016, 6:35 a.m.)


Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.


Changes
---

Added missed header includes.


Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950


Repository: mesos


Description
---

This is the first step towards separating the language used to define
the ACLs from the mechanism to query them.


Diffs (updated)
-

  include/mesos/authorizer/acls.hpp PRE-CREATION 
  include/mesos/authorizer/authorizer.hpp 
ec6c9928c55c3096c7de634f900419abbdd00886 
  include/mesos/authorizer/authorizer.proto  
  src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
  src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
  src/authorizer/acls.cpp PRE-CREATION 
  src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
  src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
  src/examples/persistent_volume_framework.cpp 
4218b1563e10aaefe9abcdc20c90c13651959790 
  src/examples/test_authorizer_module.cpp 
95d77fbff0cdfdb360a8597fbba28404b59d0042 
  src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
  src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 

Diff: https://reviews.apache.org/r/44320/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/
---

(Updated March 9, 2016, 5:58 a.m.)


Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950


Repository: mesos


Description
---

This is the first step towards separating the language used to define
the ACLs from the mechanism to query them.


Diffs (updated)
-

  include/mesos/authorizer/acls.hpp PRE-CREATION 
  include/mesos/authorizer/authorizer.hpp 
ec6c9928c55c3096c7de634f900419abbdd00886 
  include/mesos/authorizer/authorizer.proto  
  src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
  src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
  src/authorizer/acls.cpp PRE-CREATION 
  src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
  src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
  src/examples/persistent_volume_framework.cpp 
4218b1563e10aaefe9abcdc20c90c13651959790 
  src/examples/test_authorizer_module.cpp 
95d77fbff0cdfdb360a8597fbba28404b59d0042 

Diff: https://reviews.apache.org/r/44320/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/
---

(Updated March 8, 2016, 5:44 p.m.)


Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.


Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950


Repository: mesos


Description
---

This is the first step towards separating the language used to define
the ACLs from the mechanism to query them.


Diffs
-

  include/mesos/authorizer/acls.hpp PRE-CREATION 
  include/mesos/authorizer/authorizer.hpp 
ec6c9928c55c3096c7de634f900419abbdd00886 
  include/mesos/authorizer/authorizer.proto  
  src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
  src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
  src/authorizer/acls.cpp PRE-CREATION 
  src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
  src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
  src/examples/persistent_volume_framework.cpp 
4218b1563e10aaefe9abcdc20c90c13651959790 
  src/examples/test_authorizer_module.cpp 
95d77fbff0cdfdb360a8597fbba28404b59d0042 

Diff: https://reviews.apache.org/r/44320/diff/


Testing
---

make check


Thanks,

Alexander Rojas