Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-21 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/ --- (Updated March 22, 2016, 2:40 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-21 Thread Qian Zhang
> On March 21, 2016, 10:21 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto, line 17 > > > > > > Can we put this under cni::spec namespace instead? > > Qian Zhang wrote: > Ji

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-21 Thread Jie Yu
> On March 21, 2016, 2:21 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto, line 17 > > > > > > Can we put this under cni::spec namespace instead? > > Qian Zhang wrote: > Jie

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-21 Thread Qian Zhang
> On March 21, 2016, 10:21 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto, line 17 > > > > > > Can we put this under cni::spec namespace instead? Jie, did you mean putting it u

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/#review124484 --- src/slave/containerizer/mesos/isolators/network/cni/spec.proto (l

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/#review123974 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-19 Thread Qian Zhang
> On March 12, 2016, 2:51 a.m., Avinash sridharan wrote: > > Can we introduce the protobuf before the `prepare` method patch? Sure. > On March 12, 2016, 2:51 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/spec.proto, line 77 > >

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/ --- (Updated March 17, 2016, 6:06 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-18 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/#review123977 --- Fix it, then Ship it! Ship It! src/slave/containerizer/mesos/

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-16 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/ --- (Updated March 16, 2016, 3:58 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-16 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/ --- (Updated March 16, 2016, 3:48 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/#review123179 --- Can we introduce the protobuf before the `prepare` method patch?