Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

[Guangya Liu]

> On 三月 15, 2016, 1:28 a.m., Guangya Liu wrote:
> > src/tests/containerizer/runtime_isolator_tests.cpp, lines 96-98
> > 
> >
> > The comments should also be updated? Also should mention that do not 
> > want use up disk due to work dir may be copied to rootfs?
> > 
> > Ditto for other `flags.docker_store_dir`
> 
> Jie Yu wrote:
> I think the comments here still apply, right?

Do we need to mention that this can also help not use up disk?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44753/#review123561
---


On 三月 15, 2016, 12:22 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44753/
> ---
> 
> (Updated 三月 15, 2016, 12:22 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4942
> https://issues.apache.org/jira/browse/MESOS-4942
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed runtime isolator tests out of disk issue.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9fd5ea9e465f21624d3cdc0125a702528fe7548b 
>   src/tests/containerizer/runtime_isolator_tests.cpp 
> d8a000413fb30d7daaa77827287a2395d81b8b04 
> 
> Diff: https://reviews.apache.org/r/44753/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

[Jie Yu]

> On March 15, 2016, 1:28 a.m., Guangya Liu wrote:
> > src/tests/containerizer/runtime_isolator_tests.cpp, lines 96-98
> > 
> >
> > The comments should also be updated? Also should mention that do not 
> > want use up disk due to work dir may be copied to rootfs?
> > 
> > Ditto for other `flags.docker_store_dir`

I think the comments here still apply, right?


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44753/#review123561
---


On March 15, 2016, 12:22 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44753/
> ---
> 
> (Updated March 15, 2016, 12:22 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4942
> https://issues.apache.org/jira/browse/MESOS-4942
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed runtime isolator tests out of disk issue.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9fd5ea9e465f21624d3cdc0125a702528fe7548b 
>   src/tests/containerizer/runtime_isolator_tests.cpp 
> d8a000413fb30d7daaa77827287a2395d81b8b04 
> 
> Diff: https://reviews.apache.org/r/44753/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44753/#review123687
---


Ship it!




Ship It!

- Jie Yu


On March 15, 2016, 12:22 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44753/
> ---
> 
> (Updated March 15, 2016, 12:22 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4942
> https://issues.apache.org/jira/browse/MESOS-4942
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed runtime isolator tests out of disk issue.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9fd5ea9e465f21624d3cdc0125a702528fe7548b 
>   src/tests/containerizer/runtime_isolator_tests.cpp 
> d8a000413fb30d7daaa77827287a2395d81b8b04 
> 
> Diff: https://reviews.apache.org/r/44753/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44753/#review123561
---




src/tests/containerizer/runtime_isolator_tests.cpp (lines 93 - 95)


The comments should also be updated? Also should mention that do not want 
use up disk due to work dir may be copied to rootfs?

Ditto for other `flags.docker_store_dir`


- Guangya Liu


On 三月 15, 2016, 12:22 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44753/
> ---
> 
> (Updated 三月 15, 2016, 12:22 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4942
> https://issues.apache.org/jira/browse/MESOS-4942
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed runtime isolator tests out of disk issue.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9fd5ea9e465f21624d3cdc0125a702528fe7548b 
>   src/tests/containerizer/runtime_isolator_tests.cpp 
> d8a000413fb30d7daaa77827287a2395d81b8b04 
> 
> Diff: https://reviews.apache.org/r/44753/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

[Guangya Liu]

> On 三月 15, 2016, 12:58 a.m., Guangya Liu wrote:
> > @Gilbert, can you please show some detail in commit messsage to descrbe how 
> > does the fix resolve the out of disk issue? Thanks.

I saw that you just filed a JIRA and show some explantaion there, thanks!


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44753/#review123553
---


On 三月 15, 2016, 12:22 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44753/
> ---
> 
> (Updated 三月 15, 2016, 12:22 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4942
> https://issues.apache.org/jira/browse/MESOS-4942
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed runtime isolator tests out of disk issue.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9fd5ea9e465f21624d3cdc0125a702528fe7548b 
>   src/tests/containerizer/runtime_isolator_tests.cpp 
> d8a000413fb30d7daaa77827287a2395d81b8b04 
> 
> Diff: https://reviews.apache.org/r/44753/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44753/#review123553
---



@Gilbert, can you please show some detail in commit messsage to descrbe how 
does the fix resolve the out of disk issue? Thanks.

- Guangya Liu


On 三月 15, 2016, 12:22 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44753/
> ---
> 
> (Updated 三月 15, 2016, 12:22 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4942
> https://issues.apache.org/jira/browse/MESOS-4942
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed runtime isolator tests out of disk issue.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9fd5ea9e465f21624d3cdc0125a702528fe7548b 
>   src/tests/containerizer/runtime_isolator_tests.cpp 
> d8a000413fb30d7daaa77827287a2395d81b8b04 
> 
> Diff: https://reviews.apache.org/r/44753/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44753/
---

(Updated March 14, 2016, 5:22 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4942
https://issues.apache.org/jira/browse/MESOS-4942


Repository: mesos


Description
---

Fixed runtime isolator tests out of disk issue.


Diffs
-

  src/tests/containerizer/provisioner_docker_tests.cpp 
9fd5ea9e465f21624d3cdc0125a702528fe7548b 
  src/tests/containerizer/runtime_isolator_tests.cpp 
d8a000413fb30d7daaa77827287a2395d81b8b04 

Diff: https://reviews.apache.org/r/44753/diff/


Testing
---

make check

sudo ./bin/mesos-test.sh


Thanks,

Gilbert Song

Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44753/#review123274
---



Patch looks great!

Reviews applied: [44753]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 12, 2016, 4:15 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44753/
> ---
> 
> (Updated March 12, 2016, 4:15 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed runtime isolator tests out of disk issue.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9fd5ea9e465f21624d3cdc0125a702528fe7548b 
>   src/tests/containerizer/runtime_isolator_tests.cpp 
> d8a000413fb30d7daaa77827287a2395d81b8b04 
> 
> Diff: https://reviews.apache.org/r/44753/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>