Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/#review124126 --- src/tests/containerizer/provisioner_appc_tests.cpp (line 73)

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-19 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/ --- (Updated March 17, 2016, 4:44 p.m.) Review request for mesos and Jie Yu. Repo

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-19 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/ --- (Updated March 18, 2016, 12:48 a.m.) Review request for mesos and Jie Yu. Rep

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/#review124001 --- src/tests/containerizer/provisioner_appc_tests.cpp (lines 67 - 73

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-15 Thread Jojy Varghese
> On March 15, 2016, 4:56 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 587-610 > > > > > > Can you move this function to the top of this file and make it 'static'? > > Anand Mazu

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-15 Thread Anand Mazumdar
> On March 15, 2016, 4:56 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 587-610 > > > > > > Can you move this function to the top of this file and make it 'static'? > > Anand Mazu

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-15 Thread Jojy Varghese
> On March 15, 2016, 4:56 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 587-610 > > > > > > Can you move this function to the top of this file and make it 'static'? > > Anand Mazu

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-15 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/ --- (Updated March 15, 2016, 6:26 p.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-15 Thread Anand Mazumdar
> On March 15, 2016, 4:56 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 587-610 > > > > > > Can you move this function to the top of this file and make it 'static'? Wondering why

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/#review123688 --- Fix it, then Ship it! src/tests/containerizer/provisioner_appc