Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/ --- (Updated March 24, 2016, 4:15 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/#review125183 --- Fix it, then Ship it! src/tests/slave_tests.cpp (line 3267)

Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/ --- (Updated March 23, 2016, 11:22 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-23 Thread Alexander Rukletsov
> On March 18, 2016, 11:24 p.m., Ben Mahler wrote: > > src/tests/slave_tests.cpp, line 3264 > > > > > > You don't need a settle here, AWAIT_READY will settle if the clock is > > paused. > > Alexander Rukletsov

Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/ --- (Updated March 22, 2016, 5:07 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/ --- (Updated March 21, 2016, 6:33 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-21 Thread Alexander Rukletsov
> On March 18, 2016, 11:24 p.m., Ben Mahler wrote: > > src/tests/slave_tests.cpp, lines 3317-3323 > > > > > > It seems fine to expect this but arguably if what we care about in this > > test is **how** the agent

Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-21 Thread Alexander Rukletsov
> On March 21, 2016, 1 p.m., haosdent huang wrote: > > src/tests/slave_tests.cpp, line 3214 > > > > > > I notice in http://search-hadoop.com/m/0Vlr6J38NSZOXgd2 said we should > > not use negative durations. So

Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/#review124532 --- src/tests/slave_tests.cpp (line 3214)

Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-21 Thread Alexander Rukletsov
> On March 18, 2016, 11:24 p.m., Ben Mahler wrote: > > src/tests/slave_tests.cpp, line 3264 > > > > > > You don't need a settle here, AWAIT_READY will settle if the clock is > > paused. I feel that this is not

Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/ --- (Updated March 18, 2016, 5:13 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44994: Added a test for executor shutdown grace period.

2016-03-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/#review124308 --- Thanks for the test! Main high level comments are to pull out the