Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/#review126570 --- Patch looks great! Reviews applied: [45213] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 1, 2016, 6:23 a.m., zhou xing wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45213/ > --- > > (Updated April 1, 2016, 6:23 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: mesos-5055 > https://issues.apache.org/jira/browse/mesos-5055 > > > Repository: mesos > > > Description > --- > > This is the first patch to solve [MESOS-3780] > > > Diffs > - > > CHANGELOG b90078d41357c29c9102df00a735bde460e797bb > src/docker/executor.cpp 26cc88d35fc7cd913c5105f5fc4e6ae71ce59279 > src/examples/balloon_framework.cpp 1665e5bd35ad9e029372e55209802c2827be658f > src/examples/no_executor_framework.cpp > 9223d954197ebd097f57efea5299c917b24fe41e > src/examples/persistent_volume_framework.cpp > 9ce43d2b7da3f03d24473ff22cb62a88004f5f53 > src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a > src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c > src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa > src/master/allocator/mesos/hierarchical.cpp > 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132 > src/master/main.cpp 58561cffa440aaf1293e9ffe19b5685e6d2f1952 > src/master/master.hpp 1751ee1fc4d3e15df018be8bfd4f8ef2a0e32abd > src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 > src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff > src/sched/sched.cpp d989cb5f35d314dc2e03617bfdbd4b18d4efcf91 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > 323c84a3d960a196d8ba87f753814e9d43a07957 > src/slave/containerizer/mesos/launch.cpp > dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c > src/slave/main.cpp f5f21422c7cb94506b78cebf7f7341b5a078f3b2 > src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c > src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa > src/slave/state.cpp 75bdfe144d3307dc74bf48e6a0d403fbea568a6d > src/slave/status_update_manager.cpp > f6a9b3b6616abee9c55bf731855ee9b3b98606ac > src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 > src/tests/hierarchical_allocator_tests.cpp > 8f78a204d296f94f515f21511710a35c33e27255 > src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd > src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc > src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 > > Diff: https://reviews.apache.org/r/45213/diff/ > > > Testing > --- > > make > make check > > > Thanks, > > zhou xing > >
Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.
> On 三月 31, 2016, 8:25 p.m., Vinod Kone wrote: > > Can you call this out specifically in the CHANGELOG (under "Binary API > > Changes) section. > > zhou xing wrote: > Vinod?thanks for the review. I just resubmit the patch to rebase to the > latest code, please take a look. > Besides, do I need to submit another patch for the CHANGELOG chagnes or I > can inlude the CHANGELOG changes in this patch? > > Vinod Kone wrote: > You can include them here. Done, please take a look - zhou --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/#review126429 --- On 四月 1, 2016, 6:23 a.m., zhou xing wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45213/ > --- > > (Updated 四月 1, 2016, 6:23 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: mesos-5055 > https://issues.apache.org/jira/browse/mesos-5055 > > > Repository: mesos > > > Description > --- > > This is the first patch to solve [MESOS-3780] > > > Diffs > - > > CHANGELOG b90078d41357c29c9102df00a735bde460e797bb > src/docker/executor.cpp 26cc88d35fc7cd913c5105f5fc4e6ae71ce59279 > src/examples/balloon_framework.cpp 1665e5bd35ad9e029372e55209802c2827be658f > src/examples/no_executor_framework.cpp > 9223d954197ebd097f57efea5299c917b24fe41e > src/examples/persistent_volume_framework.cpp > 9ce43d2b7da3f03d24473ff22cb62a88004f5f53 > src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a > src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c > src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa > src/master/allocator/mesos/hierarchical.cpp > 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132 > src/master/main.cpp 58561cffa440aaf1293e9ffe19b5685e6d2f1952 > src/master/master.hpp 1751ee1fc4d3e15df018be8bfd4f8ef2a0e32abd > src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 > src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff > src/sched/sched.cpp d989cb5f35d314dc2e03617bfdbd4b18d4efcf91 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > 323c84a3d960a196d8ba87f753814e9d43a07957 > src/slave/containerizer/mesos/launch.cpp > dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c > src/slave/main.cpp f5f21422c7cb94506b78cebf7f7341b5a078f3b2 > src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c > src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa > src/slave/state.cpp 75bdfe144d3307dc74bf48e6a0d403fbea568a6d > src/slave/status_update_manager.cpp > f6a9b3b6616abee9c55bf731855ee9b3b98606ac > src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 > src/tests/hierarchical_allocator_tests.cpp > 8f78a204d296f94f515f21511710a35c33e27255 > src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd > src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc > src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 > > Diff: https://reviews.apache.org/r/45213/diff/ > > > Testing > --- > > make > make check > > > Thanks, > > zhou xing > >
Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/ --- (Updated 四月 1, 2016, 6:23 a.m.) Review request for mesos and Vinod Kone. Changes --- Add CHANGELOG Bugs: mesos-5055 https://issues.apache.org/jira/browse/mesos-5055 Repository: mesos Description --- This is the first patch to solve [MESOS-3780] Diffs (updated) - CHANGELOG b90078d41357c29c9102df00a735bde460e797bb src/docker/executor.cpp 26cc88d35fc7cd913c5105f5fc4e6ae71ce59279 src/examples/balloon_framework.cpp 1665e5bd35ad9e029372e55209802c2827be658f src/examples/no_executor_framework.cpp 9223d954197ebd097f57efea5299c917b24fe41e src/examples/persistent_volume_framework.cpp 9ce43d2b7da3f03d24473ff22cb62a88004f5f53 src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa src/master/allocator/mesos/hierarchical.cpp 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132 src/master/main.cpp 58561cffa440aaf1293e9ffe19b5685e6d2f1952 src/master/master.hpp 1751ee1fc4d3e15df018be8bfd4f8ef2a0e32abd src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff src/sched/sched.cpp d989cb5f35d314dc2e03617bfdbd4b18d4efcf91 src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 323c84a3d960a196d8ba87f753814e9d43a07957 src/slave/containerizer/mesos/launch.cpp dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c src/slave/main.cpp f5f21422c7cb94506b78cebf7f7341b5a078f3b2 src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa src/slave/state.cpp 75bdfe144d3307dc74bf48e6a0d403fbea568a6d src/slave/status_update_manager.cpp f6a9b3b6616abee9c55bf731855ee9b3b98606ac src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 src/tests/hierarchical_allocator_tests.cpp 8f78a204d296f94f515f21511710a35c33e27255 src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 Diff: https://reviews.apache.org/r/45213/diff/ Testing --- make make check Thanks, zhou xing
Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.
> On March 31, 2016, 8:25 p.m., Vinod Kone wrote: > > Can you call this out specifically in the CHANGELOG (under "Binary API > > Changes) section. > > zhou xing wrote: > Vinod?thanks for the review. I just resubmit the patch to rebase to the > latest code, please take a look. > Besides, do I need to submit another patch for the CHANGELOG chagnes or I > can inlude the CHANGELOG changes in this patch? You can include them here. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/#review126429 --- On April 1, 2016, 5:57 a.m., zhou xing wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45213/ > --- > > (Updated April 1, 2016, 5:57 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: mesos-3780 > https://issues.apache.org/jira/browse/mesos-3780 > > > Repository: mesos > > > Description > --- > > This is the first patch to solve [MESOS-3780] > > > Diffs > - > > src/docker/executor.cpp 26cc88d35fc7cd913c5105f5fc4e6ae71ce59279 > src/examples/balloon_framework.cpp 1665e5bd35ad9e029372e55209802c2827be658f > src/examples/no_executor_framework.cpp > 9223d954197ebd097f57efea5299c917b24fe41e > src/examples/persistent_volume_framework.cpp > 9ce43d2b7da3f03d24473ff22cb62a88004f5f53 > src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a > src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c > src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa > src/master/allocator/mesos/hierarchical.cpp > 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132 > src/master/main.cpp 58561cffa440aaf1293e9ffe19b5685e6d2f1952 > src/master/master.hpp 1751ee1fc4d3e15df018be8bfd4f8ef2a0e32abd > src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 > src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff > src/sched/sched.cpp d989cb5f35d314dc2e03617bfdbd4b18d4efcf91 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > 323c84a3d960a196d8ba87f753814e9d43a07957 > src/slave/containerizer/mesos/launch.cpp > dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c > src/slave/main.cpp f5f21422c7cb94506b78cebf7f7341b5a078f3b2 > src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c > src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa > src/slave/state.cpp 75bdfe144d3307dc74bf48e6a0d403fbea568a6d > src/slave/status_update_manager.cpp > f6a9b3b6616abee9c55bf731855ee9b3b98606ac > src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 > src/tests/hierarchical_allocator_tests.cpp > 8f78a204d296f94f515f21511710a35c33e27255 > src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd > src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc > src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 > > Diff: https://reviews.apache.org/r/45213/diff/ > > > Testing > --- > > make > make check > > > Thanks, > > zhou xing > >
Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.
> On 三月 31, 2016, 8:25 p.m., Vinod Kone wrote: > > Can you call this out specifically in the CHANGELOG (under "Binary API > > Changes) section. Vinod?thanks for the review. I just resubmit the patch to rebase to the latest code, please take a look. Besides, do I need to submit another patch for the CHANGELOG chagnes or I can inlude the CHANGELOG changes in this patch? - zhou --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/#review126429 --- On 四月 1, 2016, 5:57 a.m., zhou xing wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45213/ > --- > > (Updated 四月 1, 2016, 5:57 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: mesos-3780 > https://issues.apache.org/jira/browse/mesos-3780 > > > Repository: mesos > > > Description > --- > > This is the first patch to solve [MESOS-3780] > > > Diffs > - > > src/docker/executor.cpp 26cc88d35fc7cd913c5105f5fc4e6ae71ce59279 > src/examples/balloon_framework.cpp 1665e5bd35ad9e029372e55209802c2827be658f > src/examples/no_executor_framework.cpp > 9223d954197ebd097f57efea5299c917b24fe41e > src/examples/persistent_volume_framework.cpp > 9ce43d2b7da3f03d24473ff22cb62a88004f5f53 > src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a > src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c > src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa > src/master/allocator/mesos/hierarchical.cpp > 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132 > src/master/main.cpp 58561cffa440aaf1293e9ffe19b5685e6d2f1952 > src/master/master.hpp 1751ee1fc4d3e15df018be8bfd4f8ef2a0e32abd > src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 > src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff > src/sched/sched.cpp d989cb5f35d314dc2e03617bfdbd4b18d4efcf91 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > 323c84a3d960a196d8ba87f753814e9d43a07957 > src/slave/containerizer/mesos/launch.cpp > dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c > src/slave/main.cpp f5f21422c7cb94506b78cebf7f7341b5a078f3b2 > src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c > src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa > src/slave/state.cpp 75bdfe144d3307dc74bf48e6a0d403fbea568a6d > src/slave/status_update_manager.cpp > f6a9b3b6616abee9c55bf731855ee9b3b98606ac > src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 > src/tests/hierarchical_allocator_tests.cpp > 8f78a204d296f94f515f21511710a35c33e27255 > src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd > src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc > src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 > > Diff: https://reviews.apache.org/r/45213/diff/ > > > Testing > --- > > make > make check > > > Thanks, > > zhou xing > >
Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/ --- (Updated 四月 1, 2016, 5:57 a.m.) Review request for mesos and Vinod Kone. Changes --- rebase to the latest code Bugs: mesos-3780 https://issues.apache.org/jira/browse/mesos-3780 Repository: mesos Description --- This is the first patch to solve [MESOS-3780] Diffs (updated) - src/docker/executor.cpp 26cc88d35fc7cd913c5105f5fc4e6ae71ce59279 src/examples/balloon_framework.cpp 1665e5bd35ad9e029372e55209802c2827be658f src/examples/no_executor_framework.cpp 9223d954197ebd097f57efea5299c917b24fe41e src/examples/persistent_volume_framework.cpp 9ce43d2b7da3f03d24473ff22cb62a88004f5f53 src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa src/master/allocator/mesos/hierarchical.cpp 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132 src/master/main.cpp 58561cffa440aaf1293e9ffe19b5685e6d2f1952 src/master/master.hpp 1751ee1fc4d3e15df018be8bfd4f8ef2a0e32abd src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff src/sched/sched.cpp d989cb5f35d314dc2e03617bfdbd4b18d4efcf91 src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 323c84a3d960a196d8ba87f753814e9d43a07957 src/slave/containerizer/mesos/launch.cpp dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c src/slave/main.cpp f5f21422c7cb94506b78cebf7f7341b5a078f3b2 src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa src/slave/state.cpp 75bdfe144d3307dc74bf48e6a0d403fbea568a6d src/slave/status_update_manager.cpp f6a9b3b6616abee9c55bf731855ee9b3b98606ac src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 src/tests/hierarchical_allocator_tests.cpp 8f78a204d296f94f515f21511710a35c33e27255 src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 Diff: https://reviews.apache.org/r/45213/diff/ Testing --- make make check Thanks, zhou xing
Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/#review126490 --- Bad patch! Reviews applied: [45213] Failed command: ./support/apply-review.sh -n -r 45213 Error: 2016-03-31 23:25:40 URL:https://reviews.apache.org/r/45213/diff/raw/ [96857/96857] -> "45213.patch" [1] error: patch failed: src/cli/execute.cpp:266 error: src/cli/execute.cpp: patch does not apply error: patch failed: src/local/local.cpp:257 error: src/local/local.cpp: patch does not apply error: patch failed: src/master/master.cpp:1647 error: src/master/master.cpp: patch does not apply error: patch failed: src/slave/slave.cpp:235 error: src/slave/slave.cpp: patch does not apply error: patch failed: src/tests/cluster.cpp:501 error: src/tests/cluster.cpp: patch does not apply error: patch failed: src/tests/mesos.cpp:162 error: src/tests/mesos.cpp: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/12249/console - Mesos ReviewBot On March 23, 2016, 1:07 p.m., zhou xing wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45213/ > --- > > (Updated March 23, 2016, 1:07 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: mesos-3780 > https://issues.apache.org/jira/browse/mesos-3780 > > > Repository: mesos > > > Description > --- > > This is the first patch to solve [MESOS-3780] > > > Diffs > - > > src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e > src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e > src/examples/balloon_framework.cpp 16eea37ee327c6da1db96a6f4e3e596be5a7a6ad > src/examples/no_executor_framework.cpp > 9223d954197ebd097f57efea5299c917b24fe41e > src/examples/persistent_volume_framework.cpp > 3848e247994b511fb2b1dcde337f8f37bb7472da > src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a > src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c > src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 > src/master/allocator/mesos/hierarchical.cpp > 39a290d0db2c22e179a8f933b1a78e3a2dcefdc3 > src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 > src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 > src/master/master.cpp e6290ea686ccf17813d6faeaf2f2012f79cf3b7f > src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca > src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > 134b6c759b769cf335539e49eff817973c7f96a4 > src/slave/containerizer/mesos/launch.cpp > dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c > src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 > src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c > src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 > src/slave/state.cpp 94b6959cbca7ba14dfc70caa3402fe7d72d4757a > src/slave/status_update_manager.cpp > f6a9b3b6616abee9c55bf731855ee9b3b98606ac > src/tests/cluster.cpp 22167da70a855a39fd9c3ca980304372c70bd8d3 > src/tests/hierarchical_allocator_tests.cpp > e9cfcfc0ad8b0b89bbac459b7db39183f6c189be > src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5 > src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd > src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 > > Diff: https://reviews.apache.org/r/45213/diff/ > > > Testing > --- > > make > make check > > > Thanks, > > zhou xing > >
Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/#review126429 --- Can you call this out specifically in the CHANGELOG (under "Binary API Changes) section. - Vinod Kone On March 23, 2016, 1:07 p.m., zhou xing wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45213/ > --- > > (Updated March 23, 2016, 1:07 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: mesos-3780 > https://issues.apache.org/jira/browse/mesos-3780 > > > Repository: mesos > > > Description > --- > > This is the first patch to solve [MESOS-3780] > > > Diffs > - > > src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e > src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e > src/examples/balloon_framework.cpp 16eea37ee327c6da1db96a6f4e3e596be5a7a6ad > src/examples/no_executor_framework.cpp > 9223d954197ebd097f57efea5299c917b24fe41e > src/examples/persistent_volume_framework.cpp > 3848e247994b511fb2b1dcde337f8f37bb7472da > src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a > src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c > src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 > src/master/allocator/mesos/hierarchical.cpp > 39a290d0db2c22e179a8f933b1a78e3a2dcefdc3 > src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 > src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 > src/master/master.cpp e6290ea686ccf17813d6faeaf2f2012f79cf3b7f > src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca > src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > 134b6c759b769cf335539e49eff817973c7f96a4 > src/slave/containerizer/mesos/launch.cpp > dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c > src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 > src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c > src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 > src/slave/state.cpp 94b6959cbca7ba14dfc70caa3402fe7d72d4757a > src/slave/status_update_manager.cpp > f6a9b3b6616abee9c55bf731855ee9b3b98606ac > src/tests/cluster.cpp 22167da70a855a39fd9c3ca980304372c70bd8d3 > src/tests/hierarchical_allocator_tests.cpp > e9cfcfc0ad8b0b89bbac459b7db39183f6c189be > src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5 > src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd > src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 > > Diff: https://reviews.apache.org/r/45213/diff/ > > > Testing > --- > > make > make check > > > Thanks, > > zhou xing > >
Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/#review126405 --- Ship it! Ship It! - Vinod Kone On March 23, 2016, 1:07 p.m., zhou xing wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45213/ > --- > > (Updated March 23, 2016, 1:07 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: mesos-3780 > https://issues.apache.org/jira/browse/mesos-3780 > > > Repository: mesos > > > Description > --- > > This is the first patch to solve [MESOS-3780] > > > Diffs > - > > src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e > src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e > src/examples/balloon_framework.cpp 16eea37ee327c6da1db96a6f4e3e596be5a7a6ad > src/examples/no_executor_framework.cpp > 9223d954197ebd097f57efea5299c917b24fe41e > src/examples/persistent_volume_framework.cpp > 3848e247994b511fb2b1dcde337f8f37bb7472da > src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a > src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c > src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 > src/master/allocator/mesos/hierarchical.cpp > 39a290d0db2c22e179a8f933b1a78e3a2dcefdc3 > src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 > src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 > src/master/master.cpp e6290ea686ccf17813d6faeaf2f2012f79cf3b7f > src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca > src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > 134b6c759b769cf335539e49eff817973c7f96a4 > src/slave/containerizer/mesos/launch.cpp > dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c > src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 > src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c > src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 > src/slave/state.cpp 94b6959cbca7ba14dfc70caa3402fe7d72d4757a > src/slave/status_update_manager.cpp > f6a9b3b6616abee9c55bf731855ee9b3b98606ac > src/tests/cluster.cpp 22167da70a855a39fd9c3ca980304372c70bd8d3 > src/tests/hierarchical_allocator_tests.cpp > e9cfcfc0ad8b0b89bbac459b7db39183f6c189be > src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5 > src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd > src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 > > Diff: https://reviews.apache.org/r/45213/diff/ > > > Testing > --- > > make > make check > > > Thanks, > > zhou xing > >
