Re: Review Request 45232: Introduced subprocess watchdog option [3/7].

2016-03-28 Thread Joerg Schad
> On March 28, 2016, 5 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 46 > > > > > > When did we start making 'enum' names be in caps? There is an enum 7 > > lines above

Re: Review Request 45232: Introduced subprocess watchdog option [3/7].

2016-03-28 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45232/#review125676 --- 3rdparty/libprocess/include/process/subprocess.hpp (line 46)

Re: Review Request 45232: Introduced subprocess watchdog option [3/7].

2016-03-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45232/ --- (Updated March 28, 2016, 4:52 p.m.) Review request for mesos and Joris Van

Re: Review Request 45232: Introduced subprocess watchdog option [3/7].

2016-03-28 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45232/#review125639 --- Fix it, then Ship it!

Re: Review Request 45232: Introduced subprocess watchdog option [3/7].

2016-03-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45232/ --- (Updated March 28, 2016, 2:10 p.m.) Review request for mesos and Joris Van

Re: Review Request 45232: Introduced subprocess watchdog option.

2016-03-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45232/ --- (Updated March 28, 2016, 2:09 p.m.) Review request for mesos and Joris Van

Re: Review Request 45232: Introduced subprocess watchdog option [3/7].

2016-03-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45232/ --- (Updated March 28, 2016, noon) Review request for mesos and Joris Van

Re: Review Request 45232: Introduced subprocess watchdog option.

2016-03-28 Thread Joerg Schad
> On March 26, 2016, 4:24 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 419-423 > > > > > > I don't think it's obvious from the code that this does a fork, and > > that the

Re: Review Request 45232: Introduced subprocess watchdog option.

2016-03-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45232/ --- (Updated March 28, 2016, 11:57 a.m.) Review request for mesos and Joris Van

Re: Review Request 45232: Introduced subprocess watchdog option.

2016-03-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45232/ --- (Updated March 28, 2016, 11:47 a.m.) Review request for mesos and Joris Van