Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-04-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/#review129451 --- src/tests/mesos.hpp (lines 932 - 935)

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Yong Tang
> On March 25, 2016, 8:20 p.m., Vinod Kone wrote: > > LGTM. > > > > Can you update the CHANGELOG and call out this change in "Additonal API > > Changes" section for 0.29.0? Thanks Vinod. Just updated the CHANGELOG. - Yong --- This is

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/ --- (Updated March 25, 2016, 8:55 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/#review125464 --- LGTM. Can you update the CHANGELOG and call out this change in "A

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/#review125462 --- Ship it! LGTM - Anand Mazumdar On March 25, 2016, 5:56 p.m.,

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Yong Tang
> On March 25, 2016, 5:02 p.m., Anand Mazumdar wrote: > > Thanks for working on this. Added some comments. > > > > Also, one more additional change would be needed: > > > > Since now that the `Type` field is optional we would like to add validation > > on master to ignore the request if the `T

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/ --- (Updated March 25, 2016, 5:56 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/#review125427 --- Thanks for working on this. Added some comments. Also, one more a

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/#review125397 --- Patch looks great! Reviews applied: [45317] Passed command: expo