> On March 25, 2016, 5:02 p.m., Anand Mazumdar wrote:
> > Thanks for working on this. Added some comments.
> > 
> > Also, one more additional change would be needed:
> > 
> > Since now that the `Type` field is optional we would like to add validation 
> > on master to ignore the request if the `Type` field does not exist.
> > 
> > Here: 
> > https://github.com/apache/mesos/blob/master/src/master/validation.cpp#L61
> > 
> > Let's add a check like this:
> > 
> > ```cpp
> > if (!call.has_type()) {
> >   return Error("Expecting 'type' to be present");
> > }
> > ```

Thanks a lot for the help and detailed review. I updated the review request. 
Let me know if there are any other issues.

Since MESOS-5015 is related to MESOS-5014, I updated the review request 
https://reviews.apache.org/r/45304/ as well.

Again, thanks a lot for the help.


- Yong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45317/#review125427
-----------------------------------------------------------


On March 25, 2016, 5:56 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45317/
> -----------------------------------------------------------
> 
> (Updated March 25, 2016, 5:56 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5014
>     https://issues.apache.org/jira/browse/MESOS-5014
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fix changes Call and Event Type enums in scheduler.proto
> optional for the purpose of backwards compatibility. (MESOS-5014)
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto 
> 0049e1383f50574c3dad6a29b91811001694e82c 
>   include/mesos/v1/scheduler/scheduler.proto 
> 09fafedd06837f2307fedc6fa0e7b4460b21e5b0 
>   src/master/validation.cpp 701a5c4b279f319dde15bd8f2e97b5fd8608e578 
>   src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 
> 
> Diff: https://reviews.apache.org/r/45317/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Reply via email to