Re: Review Request 45356: Replace `AWAIT_ASSERT_EQ(true/false` with `AWAIT_ASSERT_TRUE/_FALSE`.

2016-04-03 Thread Yong Tang
> On April 3, 2016, 11:40 p.m., Michael Park wrote: > > Why did you replace `AWAIT_ASSERT_EQ(true/false` only? Why not > > `EQ(true/false` in general, so that we would catch the use of > > `EXPECT_SOME_EQ(true, expr);` in `src/tests/health_check_tests.cpp` for > > example? > > Is there perhaps

Re: Review Request 45356: Replace `AWAIT_ASSERT_EQ(true/false` with `AWAIT_ASSERT_TRUE/_FALSE`.

2016-04-03 Thread Michael Park
> On April 3, 2016, 11:40 p.m., Michael Park wrote: > > Why did you replace `AWAIT_ASSERT_EQ(true/false` only? Why not > > `EQ(true/false` in general, so that we would catch the use of > > `EXPECT_SOME_EQ(true, expr);` in `src/tests/health_check_tests.cpp` for > > example? > > Is there perhaps

Re: Review Request 45356: Replace `AWAIT_ASSERT_EQ(true/false` with `AWAIT_ASSERT_TRUE/_FALSE`.

2016-04-03 Thread Yong Tang
> On April 3, 2016, 11:40 p.m., Michael Park wrote: > > Why did you replace `AWAIT_ASSERT_EQ(true/false` only? Why not > > `EQ(true/false` in general, so that we would catch the use of > > `EXPECT_SOME_EQ(true, expr);` in `src/tests/health_check_tests.cpp` for > > example? > > Is there perhaps

Re: Review Request 45356: Replace `AWAIT_ASSERT_EQ(true/false` with `AWAIT_ASSERT_TRUE/_FALSE`.

2016-04-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45356/#review126762 --- Why did you replace `AWAIT_ASSERT_EQ(true/false` only? Why not `EQ