Re: Review Request 45537: Updated testing `Environment` to remove temp dirs after each test.

2016-04-04 Thread Joris Van Remoortere
> On March 31, 2016, 3:43 p.m., Vinod Kone wrote: > > src/tests/environment.cpp, lines 767-771 > > > > > > should this be done by the test event listener as well? Added a `TODO` as per discussion offline. - Joris

Re: Review Request 45537: Updated testing `Environment` to remove temp dirs after each test.

2016-04-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45537/ --- (Updated April 4, 2016, 10:51 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45537: Updated testing `Environment` to remove temp dirs after each test.

2016-04-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45537/#review126629 --- Fix it, then Ship it! Verified the patch fix the tests

Re: Review Request 45537: Updated testing `Environment` to remove temp dirs after each test.

2016-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45537/#review126322 --- Patch looks great! Reviews applied: [45535, 45536, 45537]

Re: Review Request 45537: Updated testing `Environment` to remove temp dirs after each test.

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45537/#review126318 --- src/tests/environment.cpp (lines 767 - 771)