Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

2016-05-11 Thread Juan Larriba
> On Abr. 18, 2016, 6:18 p.m., Vinod Kone wrote: > > support/docker_build.sh, lines 127-140 > > > > > > Hmm. I was hoping for something more generic than hard coding these 3 > > configurations. But if it's not eas

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

2016-05-10 Thread Vinod Kone
> On April 18, 2016, 6:18 p.m., Vinod Kone wrote: > > support/docker_build.sh, lines 127-140 > > > > > > Hmm. I was hoping for something more generic than hard coding these 3 > > configurations. But if it's not ea

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

2016-04-26 Thread Juan Larriba
> On Abr. 18, 2016, 6:18 p.m., Vinod Kone wrote: > > support/docker_build.sh, lines 127-140 > > > > > > Hmm. I was hoping for something more generic than hard coding these 3 > > configurations. But if it's not eas

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

2016-04-25 Thread Vinod Kone
> On April 18, 2016, 6:18 p.m., Vinod Kone wrote: > > support/docker_build.sh, lines 127-140 > > > > > > Hmm. I was hoping for something more generic than hard coding these 3 > > configurations. But if it's not ea

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

2016-04-25 Thread Juan Larriba
> On Abr. 18, 2016, 6:18 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 125 > > > > > > What is this for? It tells CMake the generator that it needs to use to generate build files. > On Abr. 18, 2016,

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

2016-04-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review129387 --- support/docker_build.sh (line 125)

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

2016-04-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review129386 --- Bad patch! Reviews applied: [45668] Failed command: ['bash', '-c

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

2016-04-18 Thread Juan Larriba
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/ --- (Updated Abr. 18, 2016, 1:58 p.m.) Review request for mesos, Alex Clemmer, Joer