> On Abr. 18, 2016, 6:18 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 125 > > <https://reviews.apache.org/r/45668/diff/5-6/?file=1337908#file1337908line125> > > > > What is this for?
It tells CMake the generator that it needs to use to generate build files. > On Abr. 18, 2016, 6:18 p.m., Vinod Kone wrote: > > support/docker_build.sh, lines 127-140 > > <https://reviews.apache.org/r/45668/diff/5-6/?file=1337908#file1337908line127> > > > > Hmm. I was hoping for something more generic than hard coding these 3 > > configurations. But if it's not easy to auto translate and the > > configuration options for CMAKE are truly different from Autotools, I'm ok > > with not doing this change here and instead have 2 different Jenkins jobs > > (one for Mesos w/ Auto-tools and one for Mesos w/ CMake); was just hoping > > we could get away with having just one Jenkins job (parameterized). I will try to submit a more generic proposal to convert from autotools to cmake parameters so the same Jenkins job can be used for building, I have had a lot of work this past week and couldn't do anything. However, I still do not understand why the BUILDTOOL or the COMPILER parameters can change between job executions and the CONFIGURATION parameter cannot change at the same time. - Juan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review129387 ----------------------------------------------------------- On Abr. 18, 2016, 1:58 p.m., Juan Larriba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45668/ > ----------------------------------------------------------- > > (Updated Abr. 18, 2016, 1:58 p.m.) > > > Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone. > > > Bugs: MESOS-5101 > https://issues.apache.org/jira/browse/MESOS-5101 > > > Repository: mesos > > > Description > ------- > > Enable CMake build for Linux as a BUILDTOOL option. > > > Diffs > ----- > > support/docker_build.sh c5917bcce4cf1f98a1808ceabe340648edd7d2a9 > > Diff: https://reviews.apache.org/r/45668/diff/ > > > Testing > ------- > > Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both > cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in > centos:7 only gcc. > > > Thanks, > > Juan Larriba > >
