Re: Review Request 45671: Added version checking for dvdcli.

2016-05-11 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/#review132629
---



Patch looks great!

Reviews applied: [45671]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 11, 2016, 2:51 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45671/
> ---
> 
> (Updated May 11, 2016, 2:51 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5267
> https://issues.apache.org/jira/browse/MESOS-5267
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added version checking for dvdcli.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
> ef43c566a51d748cca318a7578db62ee3475656d 
> 
> Diff: https://reviews.apache.org/r/45671/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> Installed dvdcli as 0.2.0, start up mesos agent will be failed.
> 
> root@kvm-002605:~/src/mesos/m1/mesos/build# dvdcli  version
> Binary: /usr/bin/dvdcli
> SemVer: 0.2.0
> OsArch: Linux-x86_64
> Branch: v0.2.0
> Commit: b2f436bcd832fed904ac7d9b94cee7174ff59e18
> Formed: Thu, 21 Apr 2016 22:43:26 CST
> 
> root@kvm-002605:~/src/mesos/m1/mesos/build# ./bin/mesos-slave.sh 
> --master=10.0.0.65:5050 --isolation=docker/volume,filesystem/linux 
> --work_dir=/tmp/mesos/slave
> I0506 13:47:45.655879 26892 main.cpp:243] Build: 2016-05-05 17:10:08 by root
> I0506 13:47:45.655985 26892 main.cpp:245] Version: 0.29.0
> I0506 13:47:45.655998 26892 main.cpp:252] Git SHA: 
> a138e2246a30c4b5c9bc3f7069ad12204dcaffbc
> I0506 13:47:45.658900 26892 containerizer.cpp:178] Using isolation: 
> docker/volume,filesystem/linux,network/cni
> I0506 13:47:45.664377 26892 linux_launcher.cpp:101] Using 
> /sys/fs/cgroup/freezer as the freezer hierarchy for the Linux launcher
> Failed to create a containerizer: Could not create MesosContainerizer: Could 
> not create isolator 'docker/volume': Unable to create docker volume driver 
> client: The docker volume driver client request 'dvdcli' version as '0.1.0' 
> but the current version is '0.2.0'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45671: Added version checking for dvdcli.

2016-05-10 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/
---

(Updated 五月 11, 2016, 2:51 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5267
https://issues.apache.org/jira/browse/MESOS-5267


Repository: mesos


Description
---

Added version checking for dvdcli.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
ef43c566a51d748cca318a7578db62ee3475656d 

Diff: https://reviews.apache.org/r/45671/diff/


Testing
---

make
make check

Installed dvdcli as 0.2.0, start up mesos agent will be failed.

root@kvm-002605:~/src/mesos/m1/mesos/build# dvdcli  version
Binary: /usr/bin/dvdcli
SemVer: 0.2.0
OsArch: Linux-x86_64
Branch: v0.2.0
Commit: b2f436bcd832fed904ac7d9b94cee7174ff59e18
Formed: Thu, 21 Apr 2016 22:43:26 CST

root@kvm-002605:~/src/mesos/m1/mesos/build# ./bin/mesos-slave.sh 
--master=10.0.0.65:5050 --isolation=docker/volume,filesystem/linux 
--work_dir=/tmp/mesos/slave
I0506 13:47:45.655879 26892 main.cpp:243] Build: 2016-05-05 17:10:08 by root
I0506 13:47:45.655985 26892 main.cpp:245] Version: 0.29.0
I0506 13:47:45.655998 26892 main.cpp:252] Git SHA: 
a138e2246a30c4b5c9bc3f7069ad12204dcaffbc
I0506 13:47:45.658900 26892 containerizer.cpp:178] Using isolation: 
docker/volume,filesystem/linux,network/cni
I0506 13:47:45.664377 26892 linux_launcher.cpp:101] Using 
/sys/fs/cgroup/freezer as the freezer hierarchy for the Linux launcher
Failed to create a containerizer: Could not create MesosContainerizer: Could 
not create isolator 'docker/volume': Unable to create docker volume driver 
client: The docker volume driver client request 'dvdcli' version as '0.1.0' but 
the current version is '0.2.0'


Thanks,

Guangya Liu

Re: Review Request 45671: Added version checking for dvdcli.

2016-05-07 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/#review132134
---




src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp (line 59)


There is a `Version` util class in `stout`, I think could use it to parse 
and compare here.


- haosdent huang


On May 6, 2016, 5:49 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45671/
> ---
> 
> (Updated May 6, 2016, 5:49 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5267
> https://issues.apache.org/jira/browse/MESOS-5267
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added version checking for dvdcli.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
> ef43c566a51d748cca318a7578db62ee3475656d 
> 
> Diff: https://reviews.apache.org/r/45671/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> Installed dvdcli as 0.2.0, start up mesos agent will be failed.
> 
> root@kvm-002605:~/src/mesos/m1/mesos/build# dvdcli  version
> Binary: /usr/bin/dvdcli
> SemVer: 0.2.0
> OsArch: Linux-x86_64
> Branch: v0.2.0
> Commit: b2f436bcd832fed904ac7d9b94cee7174ff59e18
> Formed: Thu, 21 Apr 2016 22:43:26 CST
> 
> root@kvm-002605:~/src/mesos/m1/mesos/build# ./bin/mesos-slave.sh 
> --master=10.0.0.65:5050 --isolation=docker/volume,filesystem/linux 
> --work_dir=/tmp/mesos/slave
> I0506 13:47:45.655879 26892 main.cpp:243] Build: 2016-05-05 17:10:08 by root
> I0506 13:47:45.655985 26892 main.cpp:245] Version: 0.29.0
> I0506 13:47:45.655998 26892 main.cpp:252] Git SHA: 
> a138e2246a30c4b5c9bc3f7069ad12204dcaffbc
> I0506 13:47:45.658900 26892 containerizer.cpp:178] Using isolation: 
> docker/volume,filesystem/linux,network/cni
> I0506 13:47:45.664377 26892 linux_launcher.cpp:101] Using 
> /sys/fs/cgroup/freezer as the freezer hierarchy for the Linux launcher
> Failed to create a containerizer: Could not create MesosContainerizer: Could 
> not create isolator 'docker/volume': Unable to create docker volume driver 
> client: The docker volume driver client request 'dvdcli' version as '0.1.0' 
> but the current version is '0.2.0'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45671: Added version checking for dvdcli.

2016-05-05 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/
---

(Updated 五月 6, 2016, 5:49 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5267
https://issues.apache.org/jira/browse/MESOS-5267


Repository: mesos


Description
---

Added version checking for dvdcli.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
ef43c566a51d748cca318a7578db62ee3475656d 

Diff: https://reviews.apache.org/r/45671/diff/


Testing (updated)
---

make
make check

Installed dvdcli as 0.2.0, start up mesos agent will be failed.

root@kvm-002605:~/src/mesos/m1/mesos/build# dvdcli  version
Binary: /usr/bin/dvdcli
SemVer: 0.2.0
OsArch: Linux-x86_64
Branch: v0.2.0
Commit: b2f436bcd832fed904ac7d9b94cee7174ff59e18
Formed: Thu, 21 Apr 2016 22:43:26 CST

root@kvm-002605:~/src/mesos/m1/mesos/build# ./bin/mesos-slave.sh 
--master=10.0.0.65:5050 --isolation=docker/volume,filesystem/linux 
--work_dir=/tmp/mesos/slave
I0506 13:47:45.655879 26892 main.cpp:243] Build: 2016-05-05 17:10:08 by root
I0506 13:47:45.655985 26892 main.cpp:245] Version: 0.29.0
I0506 13:47:45.655998 26892 main.cpp:252] Git SHA: 
a138e2246a30c4b5c9bc3f7069ad12204dcaffbc
I0506 13:47:45.658900 26892 containerizer.cpp:178] Using isolation: 
docker/volume,filesystem/linux,network/cni
I0506 13:47:45.664377 26892 linux_launcher.cpp:101] Using 
/sys/fs/cgroup/freezer as the freezer hierarchy for the Linux launcher
Failed to create a containerizer: Could not create MesosContainerizer: Could 
not create isolator 'docker/volume': Unable to create docker volume driver 
client: The docker volume driver client request 'dvdcli' version as '0.1.0' but 
the current version is '0.2.0'


Thanks,

Guangya Liu

Re: Review Request 45671: Added version checking for dvdcli.

2016-04-24 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/#review130343
---



Patch looks great!

Reviews applied: [45671]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 25, 2016, 3:17 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45671/
> ---
> 
> (Updated April 25, 2016, 3:17 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5267
> https://issues.apache.org/jira/browse/MESOS-5267
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added version checking for dvdcli.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
> ef43c566a51d748cca318a7578db62ee3475656d 
> 
> Diff: https://reviews.apache.org/r/45671/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45671: Added version checking for dvdcli.

2016-04-24 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/
---

(Updated 四月 25, 2016, 3:17 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5267
https://issues.apache.org/jira/browse/MESOS-5267


Repository: mesos


Description
---

Added version checking for dvdcli.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
ef43c566a51d748cca318a7578db62ee3475656d 

Diff: https://reviews.apache.org/r/45671/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45671: Added version checking for dvdcli.

2016-04-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/#review130254
---



Patch looks great!

Reviews applied: [45671]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 23, 2016, 2:16 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45671/
> ---
> 
> (Updated April 23, 2016, 2:16 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5251
> https://issues.apache.org/jira/browse/MESOS-5251
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added version checking for dvdcli.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
> c63fa02b8f13014bbcac6984a49eaa919d26b489 
> 
> Diff: https://reviews.apache.org/r/45671/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45671: Added version checking for dvdcli.

2016-04-22 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/
---

(Updated 四月 23, 2016, 2:16 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5251
https://issues.apache.org/jira/browse/MESOS-5251


Repository: mesos


Description
---

Added version checking for dvdcli.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
c63fa02b8f13014bbcac6984a49eaa919d26b489 

Diff: https://reviews.apache.org/r/45671/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45671: Added version checking for dvdcli.

2016-04-22 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/#review130202
---




src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 77 - 
103)


Let's put the check into DriverClient::create


- Jie Yu


On April 22, 2016, 9:09 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45671/
> ---
> 
> (Updated April 22, 2016, 9:09 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5104
> https://issues.apache.org/jira/browse/MESOS-5104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added version checking for dvdcli.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 915e5ae755a55a02b7dfcda88165f27346cad955 
> 
> Diff: https://reviews.apache.org/r/45671/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45671: Added version checking for dvdcli.

2016-04-22 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/
---

(Updated 四月 22, 2016, 9:09 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Summary (updated)
-

Added version checking for dvdcli.


Bugs: MESOS-5104
https://issues.apache.org/jira/browse/MESOS-5104


Repository: mesos


Description (updated)
---

Added version checking for dvdcli.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
915e5ae755a55a02b7dfcda88165f27346cad955 

Diff: https://reviews.apache.org/r/45671/diff/


Testing
---

make
make check


Thanks,

Guangya Liu