Re: Review Request 45984: Fixed the commit message hook to wrap the variables in quotes.

2016-04-11 Thread Michael Park
> On April 11, 2016, 4:48 p.m., Benjamin Bannier wrote: > > support/hooks/commit-msg, lines 26-27 > > > > > > Not part of this patch, but since we `wc` here we manually need to > > correct for it counting the

Re: Review Request 45984: Fixed the commit message hook to wrap the variables in quotes.

2016-04-11 Thread Michael Park
> On April 11, 2016, 3:19 p.m., Alexander Rukletsov wrote: > > Could you please briefly explain the problem with the globbing in the > > description? > > > > Btw, I was unaware of that patch and filed > > https://reviews.apache.org/r/46034/ . I'll discard it in favour of your > > patch. I

Re: Review Request 45984: Fixed the commit message hook to wrap the variables in quotes.

2016-04-11 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45984/ --- (Updated April 11, 2016, 5:45 p.m.) Review request for mesos, Joerg Schad,

Re: Review Request 45984: Fixed the commit message hook to wrap the variables in quotes.

2016-04-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45984/#review128134 --- Ship it! Could you please briefly explain the problem with the

Re: Review Request 45984: Fixed the commit message hook to wrap the variables in quotes.

2016-04-11 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45984/#review128130 --- Ship it! Ship It! - Joerg Schad On April 10, 2016, 6:41