Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

2016-04-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46009/#review129403 --- Ship it! rename the test variables as suggested. - Joris Van

Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

2016-04-14 Thread Alex Clemmer
> On April 12, 2016, 3:09 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/strerror_tests.cpp, lines 22-23 > > > > > > This seems generally useful? > > I think I've even seen it

Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

2016-04-14 Thread Joris Van Remoortere
> On April 12, 2016, 3:09 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/env_tests.cpp, lines 26-27 > > > > > > Please use plain names that are self descriptive. > > Alex Clemmer

Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

2016-04-14 Thread Joris Van Remoortere
> On April 12, 2016, 3:09 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/strerror_tests.cpp, lines 22-23 > > > > > > This seems generally useful? > > I think I've even seen it

Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

2016-04-13 Thread Alex Clemmer
> On April 12, 2016, 3:09 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/env_tests.cpp, line 35 > > > > > > If on L36 you assume the value, should you not `ASSERT_SOME` here? > >

Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

2016-04-13 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46009/ --- (Updated April 13, 2016, 10:05 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

2016-04-12 Thread Joris Van Remoortere
> On April 12, 2016, 3:09 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/Makefile.am, line 48 > > > > > > Are you missing an entry in `3rdparty/libprocess/3rdparty/Makefile.am`? I see it's

Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

2016-04-12 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46009/#review128420 --- 3rdparty/libprocess/3rdparty/stout/Makefile.am (line 48)