Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/#review131605 --- Patch looks great! Reviews applied: [46945, 46165] Passed

Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-05-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/ --- (Updated May 4, 2016, 12:31 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-05-03 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/#review131593 --- Ship it! Ship It! - Ben Mahler On May 3, 2016, 8:53 p.m.,

Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/#review131574 --- Bad patch! Reviews applied: [46165, 46945] Failed command:

Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-05-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/ --- (Updated May 3, 2016, 8:53 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-05-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/#review131548 --- Fix it, then Ship it!

Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-05-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/ --- (Updated May 3, 2016, 8:34 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-05-03 Thread Benjamin Bannier
> On April 14, 2016, 11:33 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp, line 95 > > > > > > This one is subtle as in principle we could use a moved-from > >

Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-04-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/#review128851 --- LGTM and is a very nice C++11 update in the spirit of the