Re: Review Request 46262: Added a LoggingTest with authentication.

2016-04-25 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46262/#review130427 --- Ship it! Ship It! - Kapil Arya On April 15, 2016, 3:01 a.m.,

Re: Review Request 46262: Added a LoggingTest with authentication.

2016-04-18 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46262/#review129309 --- Ship it! Ship It! - Alexander Rojas On April 15, 2016, 9:01

Re: Review Request 46262: Added a LoggingTest with authentication.

2016-04-15 Thread Greg Mann
> On April 15, 2016, 12:03 p.m., Alexander Rojas wrote: > > src/tests/logging_tests.cpp, line 148 > > > > > > Too keep it consistent, could you add subtests for wrong credentials > > and one which succeeds? Regardi

Re: Review Request 46262: Added a LoggingTest with authentication.

2016-04-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46262/#review129105 --- src/tests/logging_tests.cpp (line 148)

Re: Review Request 46262: Added a LoggingTest with authentication.

2016-04-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46262/#review129090 --- Patch looks great! Reviews applied: [46254, 46255, 46258, 46259,