Re: Review Request 46370: Introduced linux capabilities API.

2016-09-14 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/#review148878 --- Closing this review as Benjamin has followed up with separate

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-26 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated May 26, 2016, 3:01 p.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-25 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated May 25, 2016, 6:38 p.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/#review133860 --- src/linux/capabilities.hpp (line 37)

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-17 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated May 17, 2016, 2:59 p.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated May 13, 2016, 12:45 a.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-10 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated May 11, 2016, 4:34 a.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-09 Thread Jojy Varghese
> On May 7, 2016, 7:14 p.m., Jie Yu wrote: > > src/linux/capabilities.hpp, line 194 > > > > > > When I review the code, I found very confusing. We have > > `CapabilityInfo, CapabilityInfo::Capability, Capability,

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-08 Thread Jie Yu
> On May 7, 2016, 7:14 p.m., Jie Yu wrote: > > src/linux/capabilities.hpp, line 194 > > > > > > When I review the code, I found very confusing. We have > > `CapabilityInfo, CapabilityInfo::Capability, Capability,

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-08 Thread Jojy Varghese
> On May 7, 2016, 7:14 p.m., Jie Yu wrote: > > src/linux/capabilities.hpp, line 194 > > > > > > When I review the code, I found very confusing. We have > > `CapabilityInfo, CapabilityInfo::Capability, Capability,

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-07 Thread Jie Yu
> On May 7, 2016, 7:14 p.m., Jie Yu wrote: > > src/linux/capabilities.hpp, line 194 > > > > > > When I review the code, I found very confusing. We have > > `CapabilityInfo, CapabilityInfo::Capability, Capability,

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-07 Thread Jie Yu
> On May 7, 2016, 7:14 p.m., Jie Yu wrote: > > src/linux/capabilities.hpp, line 194 > > > > > > When I review the code, I found very confusing. We have > > `CapabilityInfo, CapabilityInfo::Capability, Capability,

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-07 Thread Jojy Varghese
> On May 7, 2016, 7:14 p.m., Jie Yu wrote: > > src/linux/capabilities.hpp, line 194 > > > > > > When I review the code, I found very confusing. We have > > `CapabilityInfo, CapabilityInfo::Capability, Capability,

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-07 Thread Jie Yu
> On May 7, 2016, 7:14 p.m., Jie Yu wrote: > > src/linux/capabilities.hpp, line 194 > > > > > > When I review the code, I found very confusing. We have > > `CapabilityInfo, CapabilityInfo::Capability, Capability,

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-07 Thread Jojy Varghese
> On May 7, 2016, 7:14 p.m., Jie Yu wrote: > > src/linux/capabilities.hpp, line 194 > > > > > > When I review the code, I found very confusing. We have > > `CapabilityInfo, CapabilityInfo::Capability, Capability,

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/#review132094 --- See my detailed comments. I think we're introducing too many

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated May 6, 2016, 5:03 p.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated May 5, 2016, 7:42 p.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-28 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated April 28, 2016, 9:44 p.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-25 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated April 26, 2016, 1:23 a.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
> On April 20, 2016, 3:15 a.m., Kevin Klues wrote: > > I added a few comments below, but in general, I feel like there are places > > this code could be greatly simplified. Specifically, it's not obvious to > > me why we need all of the different classes you define (or maybe more about > >

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
> On April 20, 2016, 3:15 a.m., Kevin Klues wrote: > > src/linux/capabilities.cpp, lines 124-125 > > > > > > This should be unnecessary. See: > >

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated April 20, 2016, 8:19 p.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated April 20, 2016, 7:05 p.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
> On April 20, 2016, 3:15 a.m., Kevin Klues wrote: > > src/linux/capabilities.hpp, lines 94-99 > > > > > > From my reading of: > > http://man7.org/linux/man-pages/man7/capabilities.7.html > > > > this enum

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
> On April 20, 2016, 3:15 a.m., Kevin Klues wrote: > > src/linux/capabilities.hpp, lines 32-33 > > > > > > This should all probably live in the mesos::internal::capabilities > > namespace. The reasons why I chose

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/#review129674 --- I added a few comments below, but in general, I feel like there