Re: Review Request 46669: Added deprecation support to Flag name.

2016-05-12 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated May 13, 2016, 4:08 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

benm's comments. NNFR.


Bugs: MESOS-5370
https://issues.apache.org/jira/browse/MESOS-5370


Repository: mesos


Description
---

This allows callers of Flag to explicitly specify a flag name or its
alias as deprecated. Loading of deprecated flag name will result in a
deprecation warning being returned.


Diffs (updated)
-

  3rdparty/stout/README.md 45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/stout/include/stout/flags/flag.hpp 
d869904d13301fd4b3fdb037e6279d3a4018ac1e 
  3rdparty/stout/include/stout/flags/flags.hpp 
02584e28b938bba738c2e32b3cb7a04a47693853 
  3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/stout/tests/flags_tests.cpp a2880a0afdc54faa4331ec8bd91929ce08c8f4a5 

Diff: https://reviews.apache.org/r/46669/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46669: Added deprecation support to Flag name.

2016-05-12 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/#review132997
---


Fix it, then Ship it!





3rdparty/stout/include/stout/flags/flag.hpp (line 23)


whoops?



3rdparty/stout/include/stout/flags/flag.hpp (lines 52 - 57)


Maybe `s/name_/name/` and `s/name/n/` or `s/name/name_`?



3rdparty/stout/include/stout/flags/flags.hpp (line 899)


Past tense since the caller will log the warning after load completes?



3rdparty/stout/tests/flags_tests.cpp (lines 271 - 272)


Can you update all of these existing tests to expect no warnings?



3rdparty/stout/tests/flags_tests.cpp (line 502)


Can you use the `->` operator here?

EXPECT?

Also can you add an expectation on the message?


- Ben Mahler


On May 12, 2016, 10:42 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46669/
> ---
> 
> (Updated May 12, 2016, 10:42 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
> 
> 
> Bugs: MESOS-5370
> https://issues.apache.org/jira/browse/MESOS-5370
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows callers of Flag to explicitly specify a flag name or its
> alias as deprecated. Loading of deprecated flag name will result in a
> deprecation warning being returned.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/README.md 45dd8f39de9fa34cc11befbe842319079685db02 
>   3rdparty/stout/include/stout/flags/flag.hpp 
> d869904d13301fd4b3fdb037e6279d3a4018ac1e 
>   3rdparty/stout/include/stout/flags/flags.hpp 
> 02584e28b938bba738c2e32b3cb7a04a47693853 
>   3rdparty/stout/include/stout/subcommand.hpp 
> 4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
>   3rdparty/stout/tests/flags_tests.cpp 
> a2880a0afdc54faa4331ec8bd91929ce08c8f4a5 
> 
> Diff: https://reviews.apache.org/r/46669/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46669: Added deprecation support to Flag name.

2016-05-12 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated May 12, 2016, 10:42 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

updated bug id.


Bugs: MESOS-5370
https://issues.apache.org/jira/browse/MESOS-5370


Repository: mesos


Description
---

This allows callers of Flag to explicitly specify a flag name or its
alias as deprecated. Loading of deprecated flag name will result in a
deprecation warning being returned.


Diffs
-

  3rdparty/stout/README.md 45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/stout/include/stout/flags/flag.hpp 
d869904d13301fd4b3fdb037e6279d3a4018ac1e 
  3rdparty/stout/include/stout/flags/flags.hpp 
02584e28b938bba738c2e32b3cb7a04a47693853 
  3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/stout/tests/flags_tests.cpp a2880a0afdc54faa4331ec8bd91929ce08c8f4a5 

Diff: https://reviews.apache.org/r/46669/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46669: Added deprecation support to Flag name.

2016-05-12 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated May 12, 2016, 8:53 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

updated description.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description (updated)
---

This allows callers of Flag to explicitly specify a flag name or its
alias as deprecated. Loading of deprecated flag name will result in a
deprecation warning being returned.


Diffs (updated)
-

  3rdparty/stout/README.md 45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/stout/include/stout/flags/flag.hpp 
d869904d13301fd4b3fdb037e6279d3a4018ac1e 
  3rdparty/stout/include/stout/flags/flags.hpp 
02584e28b938bba738c2e32b3cb7a04a47693853 
  3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/stout/tests/flags_tests.cpp a2880a0afdc54faa4331ec8bd91929ce08c8f4a5 

Diff: https://reviews.apache.org/r/46669/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46669: Added deprecation support to Flag name.

2016-05-12 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated May 12, 2016, 8:45 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

rebased.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Added deprecation support to Flag name.


Diffs (updated)
-

  3rdparty/stout/README.md 45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/stout/include/stout/flags/flag.hpp 
d869904d13301fd4b3fdb037e6279d3a4018ac1e 
  3rdparty/stout/include/stout/flags/flags.hpp 
02584e28b938bba738c2e32b3cb7a04a47693853 
  3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/stout/tests/flags_tests.cpp a2880a0afdc54faa4331ec8bd91929ce08c8f4a5 

Diff: https://reviews.apache.org/r/46669/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46669: Added deprecation support to Flag name.

2016-05-11 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated May 12, 2016, 1:37 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

rebased.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Added deprecation support to Flag name.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
  3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
66e16abe914e2a1ee7599bab857ff478b7ec20dc 

Diff: https://reviews.apache.org/r/46669/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46669: Added deprecation support to Flag name.

2016-04-29 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated April 30, 2016, 3:44 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Added deprecation support to Flag name.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
  3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
66e16abe914e2a1ee7599bab857ff478b7ec20dc 

Diff: https://reviews.apache.org/r/46669/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46669: Added deprecation support to Flag name.

2016-04-29 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated April 30, 2016, 2:01 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

mpark's comments.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Added deprecation support to Flag name.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
  3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
66e16abe914e2a1ee7599bab857ff478b7ec20dc 

Diff: https://reviews.apache.org/r/46669/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46669: Added deprecation support to Flag name.

2016-04-29 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated April 29, 2016, 7:08 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

updated testing section.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Added deprecation support to Flag name.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
  3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
66e16abe914e2a1ee7599bab857ff478b7ec20dc 

Diff: https://reviews.apache.org/r/46669/diff/


Testing (updated)
---

make check


Thanks,

Vinod Kone

Re: Review Request 46669: Added deprecation support to Flag name.

2016-04-28 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated April 29, 2016, 3:28 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

Ben's comments.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Added deprecation support to Flag name.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
  3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
66e16abe914e2a1ee7599bab857ff478b7ec20dc 

Diff: https://reviews.apache.org/r/46669/diff/


Testing
---

Tested manually by running ./bin/mesos-master.sh --authenticate

The one caveat is that the deprecation warning might be printed before logging 
the library is initialized (e.g., master/main.cpp calls flags.load() before 
logging::initialize(flags)).


Thanks,

Vinod Kone

Re: Review Request 46669: Added deprecation support to Flag name.

2016-04-28 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/#review130675
---




3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp (line 91)


s/effectiveName/effective_name/



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 951 - 
955)


return warning as a string/Warning instead of directly logging here.


- Vinod Kone


On April 26, 2016, 1:08 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46669/
> ---
> 
> (Updated April 26, 2016, 1:08 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added deprecation support to Flag name.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
> 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/46669/diff/
> 
> 
> Testing
> ---
> 
> Tested manually by running ./bin/mesos-master.sh --authenticate
> 
> The one caveat is that the deprecation warning might be printed before 
> logging the library is initialized (e.g., master/main.cpp calls flags.load() 
> before logging::initialize(flags)).
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>