Re: Review Request 47168: Windows: Implement `kill` and `killtree`.

2016-05-10 Thread Alex Clemmer
> On May 10, 2016, 5:41 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/kill.hpp, line > > 30 > > > > > > If we don't mean to expose `kill_process` here, can we please put

Re: Review Request 47168: Windows: Implement `kill` and `killtree`.

2016-05-10 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47168/#review132482 ---

Re: Review Request 47168: Windows: Implement `kill` and `killtree`.

2016-05-10 Thread Joris Van Remoortere
> On May 10, 2016, 4:17 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/kill.hpp, line > > 39 > > > > > > Why a `shared_ptr` instead of a `unique_ptr`? I'm guessing

Re: Review Request 47168: Windows: Implement `kill` and `killtree`.

2016-05-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47168/#review132458 ---