> On May 10, 2016, 4:17 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/kill.hpp, line > > 39 > > <https://reviews.apache.org/r/47168/diff/1/?file=1377773#file1377773line39> > > > > Why a `shared_ptr` instead of a `unique_ptr`?
I'm guessing this should be a `SharedHandle`? - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47168/#review132458 ----------------------------------------------------------- On May 10, 2016, 8:54 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47168/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 8:54 a.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Windows: Implement `kill` and `killtree`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 33ddb06e25920096f2d16d4f372129ee2f6a8721 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/kill.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/kill.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/kill.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 3828c53c0dbbf370d642189998af75b9af434e9d > > Diff: https://reviews.apache.org/r/47168/diff/ > > > Testing > ------- > > Windows: build/test w/ Marathon > > > Thanks, > > Daniel Pravat > >
