Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133527 --- src/master/quota_handler.cpp (line 513)

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/ --- (Updated May 17, 2016, 12:39 p.m.) Review request for mesos, Adam B and Alexand

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133513 --- Fix it, then Ship it! I'll take care of the outstanding issues

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

> On May 16, 2016, 6:06 p.m., Alexander Rukletsov wrote: > > src/master/master.hpp, line 1022 > > > > > > Do you still need `request`? We still need `jsonp` argument to be passed. I feel keeping request captured w

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133491 --- src/master/quota_handler.cpp (lines 518 - 520)

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/ --- (Updated May 17, 2016, 5:06 a.m.) Review request for mesos, Adam B and Alexande

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133388 --- Okay, almost there. We should be good after one more pass. src/m

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133200 --- Patch looks great! Reviews applied: [47274] Passed command: expo

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/ --- (Updated May 13, 2016, 6:48 p.m.) Review request for mesos, Adam B and Alexande

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/ --- (Updated May 13, 2016, 6:47 p.m.) Review request for mesos, Adam B and Alexande

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

> On May 13, 2016, 5:38 p.m., Zhitao Li wrote: > > src/master/quota_handler.cpp, line 464 > > > > > > I'd like to keep using vector because we know the expected size in the > > beginning and can reserve the capacity

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133164 --- src/master/quota_handler.cpp (line 464)

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

> On May 13, 2016, 2:17 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, line 464 > > > > > > If we eliminate intermediate vector, we will be looping thorugh hashmap > > and list simultaneously. I

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133135 --- Patch looks great! Reviews applied: [47222, 47274] Passed comman

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

> On May 13, 2016, 2:17 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, lines 441-447 > > > > > > Do we really need this copy? Or we can directly use `master->quotas`? After a second thought, most

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133094 --- Looks good. Could you please make this patch self-contained, i.e.,