Re: Review Request 47336: Fixed FTS handle leak issue in xfs isolator.

2016-05-13 Thread Guangya Liu
> On 五月 13, 2016, 5:22 p.m., James Peach wrote: > > Looks fine. Consider switching to ``unique_ptr``, since we only check the > > ``fts_close`` error 1 of 3 times. @James Peach, can you please show more detail for what do you mean? How to switch to `unique_prt`? Do you want me to submit

Re: Review Request 47336: Fixed FTS handle leak issue in xfs isolator.

2016-05-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47336/#review133205 --- Ship it! Ship It! - Gilbert Song On May 13, 2016, 12:09

Re: Review Request 47336: Fixed FTS handle leak issue in xfs isolator.

2016-05-13 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47336/#review133158 --- Ship it! Looks fine. Consider switching to ``unique_ptr``,

Re: Review Request 47336: Fixed FTS handle leak issue in xfs isolator.

2016-05-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47336/#review133139 --- Ship it! Ship It! - Timothy Chen On May 13, 2016, 7:09

Re: Review Request 47336: Fixed FTS handle leak issue in xfs isolator.

2016-05-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47336/#review133095 --- Patch looks great! Reviews applied: [47336] Passed command: