Re: Review Request 47363: Introduced a driver to v1 executor shim/adapter.

2016-05-17 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47363/ --- (Updated May 17, 2016, 7:57 p.m.) Review request for mesos, Joris Van

Re: Review Request 47363: Introduced a driver to v1 executor shim/adapter.

2016-05-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47363/#review133602 --- Fix it, then Ship it! include/mesos/v1/executor.hpp (line 74)

Re: Review Request 47363: Introduced a driver to v1 executor shim/adapter.

2016-05-16 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47363/ --- (Updated May 16, 2016, 11:51 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 47363: Introduced a driver to v1 executor shim/adapter.

2016-05-16 Thread Anand Mazumdar
> On May 15, 2016, 12:55 a.m., Vinod Kone wrote: > > include/mesos/v1/executor.hpp, line 38 > > > > > > We don't name our interfaces as *Interface :) Is there an alternative > > name we could use? > > > >

Re: Review Request 47363: Introduced a driver to v1 executor shim/adapter.

2016-05-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47363/#review133429 --- src/executor/v0_v1executor.cpp (lines 17 - 19)

Re: Review Request 47363: Introduced a driver to v1 executor shim/adapter.

2016-05-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47363/#review133289 --- include/mesos/v1/executor.hpp (line 38)

Re: Review Request 47363: Introduced a driver to v1 executor shim/adapter.

2016-05-14 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47363/ --- (Updated May 14, 2016, 8:39 a.m.) Review request for mesos and Vinod Kone.